From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27331 invoked by alias); 3 Apr 2002 01:22:08 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27320 invoked from network); 3 Apr 2002 01:22:07 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 3 Apr 2002 01:22:07 -0000 Received: from redhat.com (notinuse.cygnus.com [205.180.231.12]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id RAA03504; Tue, 2 Apr 2002 17:22:06 -0800 (PST) Message-ID: <3CAA5699.FF4450A@redhat.com> Date: Tue, 02 Apr 2002 17:22:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Daniel Jacobowitz CC: gdb-patches@sources.redhat.com, Andrew Cagney Subject: Re: [RFA/mi-testsuite] XFAIL mi*-console.exp References: <20020402194252.A20826@nevyn.them.org> <3CAA4F86.7CE409C8@redhat.com> <20020402200140.A21552@nevyn.them.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-04/txt/msg00050.txt.bz2 Daniel Jacobowitz wrote: > > On Tue, Apr 02, 2002 at 04:40:38PM -0800, Michael Snyder wrote: > > Daniel Jacobowitz wrote: > > > > > > These tests are testing for a feature that exists either nowhere or just in > > > simulators and some remote stubs: that the inferior's output goes through > > > GDB and is properly encoded by the MI layer. Since support isn't there for > > > many remote debugging stubs or for native, I think these two tests should be > > > XFAIL'd. Does that make sense, Andrew? If so, OK to commit this? > > > > There is a dejagnu variable that you can use to see > > whether this is supported... lemme see... > > > > Ah -- here you go. You want to do something like the following: > > > > if { ![gdb_skip_stdio_test "Hello message"] } then { > > do the "hello message" test... > > Isn't gdb_skip_stdio_test for things where there's no way at all to see > the output? grep, grep,... > if [target_info exists gdb,noinferiorio] { Well, yes... and that's only going to be true for remote stubs and simulators that don't support sending target output thru the gdb console. Isn't that what you want? I'm not familiar with these tests. Do you also need to exclude it from running on natives? How about if { ![isnative && ![gdb_skip_stdio_test ... > > That's not quite the same thing. You can run stdio test on a native > target, and (while GDB never sees the output) DejaGNU will. I could > do this instead, though... revised patch attached. > > -- > Daniel Jacobowitz Carnegie Mellon University > MontaVista Software Debian GNU/Linux Developer > > 2002-04-02 Daniel Jacobowitz > > * gdb.mi/mi-console.exp: Accept native console output as an > XFAIL. Don't run the test if we don't have inferior IO. > * gdb.mi/mi0-console.exp: Likewise. > > Index: testsuite/gdb.mi/mi-console.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-console.exp,v > retrieving revision 1.7 > diff -u -p -r1.7 mi-console.exp > --- mi-console.exp 2001/08/19 01:23:43 1.7 > +++ mi-console.exp 2002/04/03 01:00:34 > @@ -79,7 +79,8 @@ gdb_expect { > } > } > > -gdb_expect { > +if {![gdb_skip_stdio_test "Hello message"]} { > + gdb_expect { > -re "@\"H\"\r\n.*@\"e\"\r\n.*@\"l\"\r\n.*@\"l\"\r\n.*@\"o\"\r\n.*@\" \"\r\n.*@\"\\\\\\\\\"\r\n.*@\"\\\\\"\"\r\n.*@\"!\"\r\n.*@\"\\\\r\"\r\n.*@\"\\\\n\"\r\n" { > pass "Hello message" > } > @@ -92,11 +93,12 @@ gdb_expect { > # multiple event sources to channel the output back through the > # MI. > > - fail "Hello message (known bug)" > + xfail "Hello message (known limitation)" > } > timeout { > fail "Hello message (timeout)" > } > + } > } > > gdb_expect { > Index: testsuite/gdb.mi/mi0-console.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi0-console.exp,v > retrieving revision 1.5 > diff -u -p -r1.5 mi0-console.exp > --- mi0-console.exp 2001/08/19 01:23:43 1.5 > +++ mi0-console.exp 2002/04/03 01:00:34 > @@ -79,7 +79,8 @@ gdb_expect { > } > } > > -gdb_expect { > +if {![gdb_skip_stdio_test "Hello message"]} { > + gdb_expect { > -re "@\"H\"\r\n.*@\"e\"\r\n.*@\"l\"\r\n.*@\"l\"\r\n.*@\"o\"\r\n.*@\" \"\r\n.*@\"\\\\\\\\\"\r\n.*@\"\\\\\"\"\r\n.*@\"!\"\r\n.*@\"\\\\r\"\r\n.*@\"\\\\n\"\r\n" { > pass "Hello message" > } > @@ -92,11 +93,12 @@ gdb_expect { > # multiple event sources to channel the output back through the > # MI. > > - fail "Hello message (known bug)" > + xfail "Hello message (known limitation)" > } > timeout { > fail "Hello message (timeout)" > } > + } > } > > gdb_expect {