From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-13767-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 29311 invoked by alias); 31 Mar 2002 05:05:33 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 29303 invoked from network); 31 Mar 2002 05:05:32 -0000
Received: from unknown (HELO localhost.redhat.com) (66.31.105.161)
  by sources.redhat.com with SMTP; 31 Mar 2002 05:05:32 -0000
Received: from cygnus.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 3B9DD3C41; Fri, 29 Mar 2002 12:35:34 -0500 (EST)
Message-ID: <3CA4A5E5.7060904@cygnus.com>
Date: Sat, 30 Mar 2002 21:05:00 -0000
From: Andrew Cagney <ac131313@cygnus.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.9) Gecko/20020328
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Daniel Jacobowitz <drow@mvista.com>,
	gdb-patches@sources.redhat.com
Subject: Re: Minor off-by-one error in command_line_handler
References: <20020327000106.A24311@molenda.com> <20020329025400.A25885@nevyn.them.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-03/txt/msg00619.txt.bz2

It at least deserves a comment :-)

>  #define ALL_BLOCK_SYMBOLS(bl, i, sym)			\
>  	for ((i) = 0, (sym) = BLOCK_SYM ((bl), (i));	\
>  	     (i) < BLOCK_NSYMS ((bl));			\
> -	     ++(i), (sym) = BLOCK_SYM ((bl), (i)))
> +	     ++(i), (sym) = ((i) < BLOCK_NSYMS ((bl)))	\
> +			    ? BLOCK_SYM ((bl), (i))	\
> +			    : NULL)
>  

Andrew