Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@redhat.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: Kevin Buettner <kevinb@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc] Delete write_fp() and friends
Date: Thu, 28 Mar 2002 12:21:00 -0000	[thread overview]
Message-ID: <3CA378BC.A127FBDB@redhat.com> (raw)
In-Reply-To: <3CA3768C.3020906@cygnus.com>

Andrew Cagney wrote:
> 
> > On Mar 28, 10:28am, Michael Snyder wrote:
> >
> >
> >> > Well, almost, I left dwarf2cfi.c's write_fp() as is - someone might be
> >> > interested in the code.
> >> >
> >> > Assuming no issues are raised, and my builds come back clean, I'll
> >> > commit it next week.
> >
> >>
> >> So what should calls to write_fp be replaced with?
> >
> >
> > It looks to me like there was only one call to write_fp() and that
> > occurred in sparc-tdep.c.  Andrew replaced that call with a call to
> > write_register().
> 
> I need to examine that a bit more carefully though.
> 
> > But, ahem, it would've been nice for Andrew to tell us this in the
> > prefatory text preceding the patch.
> 
> True, it was intentional - to see who was awake.  I figured that a patch
> to delete write_fp() was going to be examined very very carefully :-)

If no one but Sparc is using it, I'm not very worried
(as long as you take care of sparc).


  reply	other threads:[~2002-03-28 20:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-03-27 19:32 Andrew Cagney
2002-03-28 10:39 ` Michael Snyder
2002-03-28 10:55   ` Kevin Buettner
2002-03-28 12:03     ` Andrew Cagney
2002-03-28 12:21       ` Michael Snyder [this message]
2002-03-28 12:41         ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CA378BC.A127FBDB@redhat.com \
    --to=msnyder@redhat.com \
    --cc=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox