From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-13659-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 14527 invoked by alias); 26 Mar 2002 23:24:45 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 14499 invoked from network); 26 Mar 2002 23:24:45 -0000
Received: from unknown (HELO cygnus.com) (205.180.230.5)
  by sources.redhat.com with SMTP; 26 Mar 2002 23:24:45 -0000
Received: from redhat.com (rtl.cygnus.com [205.180.230.21])
	by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id PAA28406;
	Tue, 26 Mar 2002 15:24:42 -0800 (PST)
Message-ID: <3CA102BB.72DF85F4@redhat.com>
Date: Tue, 26 Mar 2002 15:24:00 -0000
From: Fernando Nasser <fnasser@redhat.com>
Organization: Red Hat Canada
X-Accept-Language: en
MIME-Version: 1.0
To: Michael Snyder <msnyder@redhat.com>
CC: fnf@redhat.com, gdb-patches@sources.redhat.com, fnf@ninemoons.com
Subject: Re: [RFA] Accept compiler internal use of memcpy/bcopy for structs
References: <200203260322.g2Q3MZb11877@fred.ninemoons.com> <3CA0F7BD.FB3F4EAF@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-03/txt/msg00511.txt.bz2

Michael Snyder wrote:
> 
> Fred Fish wrote:
> >
> > > Would you please try the attached modification of your patch,
> > > and let me know if it is acceptable?
> >
> > Yes, that works.  I've attached the actual patch I tried (there was an
> > extra '}' in the patch you suggested).  OK to check in?
> 
> OK by me...
> 

Thanks for looking into this one Michael.

And thanks for the patch Fred.  Please check it in.

Regards to all.

Fernando

> >
> > -Fred
> >
> > 2002-03-25  Fred Fish  <fnf@redhat.com>
> >
> >         * gdb.base/step-test.exp: Accept stopping in memcpy/bcopy when we
> >         have debugging info for those functions and the compiler uses them
> >         internally to copy structs around.
> >
> > Index: gdb.base/step-test.exp
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/step-test.exp,v
> > retrieving revision 1.3
> > diff -c -p -r1.3 step-test.exp
> > *** step-test.exp       2001/03/06 08:21:51     1.3
> > --- step-test.exp       2002/03/26 03:20:34
> > *************** gdb_test \
> > *** 212,220 ****
> >   gdb_test "continue" \
> >            ".*Breakpoint ${decimal},.*large_struct_by_value.*" \
> >          "run to pass large struct"
> > ! gdb_test "step" \
> > !          ".*step-test.exp: arrive here 1.*" \
> > !          "large struct by value"
> >
> >   gdb_continue_to_end "step-test.exp"
> >
> > --- 212,234 ----
> >   gdb_test "continue" \
> >            ".*Breakpoint ${decimal},.*large_struct_by_value.*" \
> >          "run to pass large struct"
> > ! send_gdb "step\n"
> > ! gdb_expect {
> > !     -re ".*step-test.exp: arrive here 1.*$gdb_prompt $" {
> > !       pass "large struct by value"
> > !     }
> > !     -re ".*(memcpy|bcopy).*$gdb_prompt $" {
> > !       send_gdb "finish\n" ; gdb_expect -re "$gdb_prompt $"
> > !       send_gdb "step\n"
> > !       exp_continue
> > !     }
> > !     -re ".*$gdb_prompt $" {
> > !       fail "large struct by value"
> > !     }
> > !     timeout {
> > !       fail "large struct by value (timeout)"
> > !     }
> > ! }
> >
> >   gdb_continue_to_end "step-test.exp"
> >

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9