From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26182 invoked by alias); 26 Mar 2002 22:53:42 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26154 invoked from network); 26 Mar 2002 22:53:41 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 26 Mar 2002 22:53:41 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 63E313EDA; Tue, 26 Mar 2002 17:51:39 -0500 (EST) Message-ID: <3CA0FB7B.3020302@cygnus.com> Date: Tue, 26 Mar 2002 14:53:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.8) Gecko/20020210 X-Accept-Language: en-us MIME-Version: 1.0 To: Daniel Berlin Cc: Jim Blandy , gdb-patches@sources.redhat.com Subject: Re: [PATCH] Let dwarf2 CFI's execute_stack_op be used outside of CFI References: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-03/txt/msg00509.txt.bz2 > > Whoops. > You're right. > I must have merged it while on crack or something. > I *meant* to add the frame argument, and only require *either* the > context argument (Which is what it currently takes, a CFA context) or the > frame, but it looks like I messed up. > > What it *should* look like is closer to the one from the WIP i sent. It > should call get_saved_register with the frame argument if the context is > null, or get_reg with the context argument if the context is not null. That is what I was asking I wrote: >> Shouldn't the dwarf2 location expression evaluator be separated out >> (dwarf2loc?) and be parameterized with both the frame it is to operate >> within and the expression it is to evaluate. You wrote: > Yeah, so? > I'm doing this incrementally. > The first step is adding an external entry point, then moving it outside > of dwarf2cfi.c, then modifying it to take a struct frame info, etc. > I'm trying to do this without breaking anything. > It currently *is* parameterized with both the frame and expression. The > problem is that the frame it expects isn't a "struct frame_info", it's a > dwarf2 frame context. Andrew