From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-13656-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 9918 invoked by alias); 26 Mar 2002 22:46:33 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 9875 invoked from network); 26 Mar 2002 22:46:31 -0000
Received: from unknown (HELO cygnus.com) (205.180.230.5)
  by sources.redhat.com with SMTP; 26 Mar 2002 22:46:31 -0000
Received: from redhat.com (notinuse.cygnus.com [205.180.231.12])
	by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id OAA23491;
	Tue, 26 Mar 2002 14:46:27 -0800 (PST)
Message-ID: <3CA0F7BD.FB3F4EAF@redhat.com>
Date: Tue, 26 Mar 2002 14:46:00 -0000
From: Michael Snyder <msnyder@redhat.com>
Organization: Red Hat, Inc.
X-Accept-Language: en
MIME-Version: 1.0
To: fnf@redhat.com
CC: gdb-patches@sources.redhat.com, fnf@ninemoons.com
Subject: Re: [RFA] Accept compiler internal use of memcpy/bcopy for structs
References: <200203260322.g2Q3MZb11877@fred.ninemoons.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-03/txt/msg00508.txt.bz2

Fred Fish wrote:
> 
> > Would you please try the attached modification of your patch,
> > and let me know if it is acceptable?
> 
> Yes, that works.  I've attached the actual patch I tried (there was an
> extra '}' in the patch you suggested).  OK to check in?

OK by me...

> 
> -Fred
> 
> 2002-03-25  Fred Fish  <fnf@redhat.com>
> 
>         * gdb.base/step-test.exp: Accept stopping in memcpy/bcopy when we
>         have debugging info for those functions and the compiler uses them
>         internally to copy structs around.
> 
> Index: gdb.base/step-test.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/step-test.exp,v
> retrieving revision 1.3
> diff -c -p -r1.3 step-test.exp
> *** step-test.exp       2001/03/06 08:21:51     1.3
> --- step-test.exp       2002/03/26 03:20:34
> *************** gdb_test \
> *** 212,220 ****
>   gdb_test "continue" \
>            ".*Breakpoint ${decimal},.*large_struct_by_value.*" \
>          "run to pass large struct"
> ! gdb_test "step" \
> !          ".*step-test.exp: arrive here 1.*" \
> !          "large struct by value"
> 
>   gdb_continue_to_end "step-test.exp"
> 
> --- 212,234 ----
>   gdb_test "continue" \
>            ".*Breakpoint ${decimal},.*large_struct_by_value.*" \
>          "run to pass large struct"
> ! send_gdb "step\n"
> ! gdb_expect {
> !     -re ".*step-test.exp: arrive here 1.*$gdb_prompt $" {
> !       pass "large struct by value"
> !     }
> !     -re ".*(memcpy|bcopy).*$gdb_prompt $" {
> !       send_gdb "finish\n" ; gdb_expect -re "$gdb_prompt $"
> !       send_gdb "step\n"
> !       exp_continue
> !     }
> !     -re ".*$gdb_prompt $" {
> !       fail "large struct by value"
> !     }
> !     timeout {
> !       fail "large struct by value (timeout)"
> !     }
> ! }
> 
>   gdb_continue_to_end "step-test.exp"
>