From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4665 invoked by alias); 26 Mar 2002 17:26:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4657 invoked from network); 26 Mar 2002 17:26:45 -0000 Received: from unknown (HELO kerberos.suse.cz) (195.47.106.10) by sources.redhat.com with SMTP; 26 Mar 2002 17:26:45 -0000 Received: from chimera.suse.cz (chimera.suse.cz [10.20.0.2]) by kerberos.suse.cz (SuSE SMTP server) with ESMTP id 0931459D348 for ; Tue, 26 Mar 2002 18:26:44 +0100 (CET) Received: from suse.cz (leviathan.suse.cz [10.20.1.56]) by chimera.suse.cz (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id g2QHQhp30489 for ; Tue, 26 Mar 2002 18:26:43 +0100 X-Authentication-Warning: chimera.suse.cz: Host leviathan.suse.cz [10.20.1.56] claimed to be suse.cz Message-ID: <3CA0AF53.8030609@suse.cz> Date: Tue, 26 Mar 2002 09:26:00 -0000 From: Michal Ludvig Organization: SuSE CR User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.9) Gecko/20020310 X-Accept-Language: cs, cz, en MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: [RFA] x86-64 segment registers handling Content-Type: multipart/mixed; boundary="------------060801040502030600010700" X-SW-Source: 2002-03/txt/msg00491.txt.bz2 This is a multi-part message in MIME format. --------------060801040502030600010700 Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1327 Hi all, this patch synces gdb with recent ABI changes in x86-64 kernel, which added segment registers to user_regs_struct in corefile and ptrace() call. Because it was hard to find all places which could depend on this change I also did a cleanup. I joined most of registers information to one structure at the beginning of x86-64-tdep.c to make it more readable and maintainable and changed some "anonymous constants" (numbers) to derivatives of #defines. Can I commit? Index: ChangeLog * x86-64-tdep.h (X86_64_NUM_REGS) (X86_64_NUM_GREGS): Delete #defines (x86_64_num_regs) (x86_64_num_gregs): Added extern variables. * x86-64-linux-nat.c (x86_64_regmap): Swapped RBX <> RDX, added DS, ES, FD, GS (x86_64_linux_dr_get_status), (supply_gregset), (fill_gregset): Changed X86_64_NUM_GREGS to x86_64_num_gregs * x86-64-tdep.c (x86_64_register_raw_size_table): Delete (x86_64_register_info_table): Add (X86_64_NUM_REGS, X86_64_NUM_GREGS): Add (x86_64_register_raw_size), (x86_64_register_virtual_type), (x86_64_register_name), (_initialize_x86_64_tdep): Changed to reflect new general x86_64_register_info_table. (i386_gdbarch_init): gdbarch_register_bytes is now set dynamicaly during initialization. Michal Ludvig -- * SuSE CR, s.r.o * mludvig@suse.cz * +420 2 9654 5373 * http://www.suse.cz --------------060801040502030600010700 Content-Type: text/plain; name="x8664-05.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline; filename="x8664-05.diff" Content-length: 14584 Index: x86-64-tdep.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/x86-64-tdep.c,v retrieving revision 1.11 diff -c -3 -p -r1.11 x86-64-tdep.c *** x86-64-tdep.c 2002/03/25 07:59:16 1.11 --- x86-64-tdep.c 2002/03/26 16:56:52 *************** *** 35,75 **** =20=20 /* Register numbers of various important registers. */ #define RAX_REGNUM 0 ! #define RDX_REGNUM 1 #define RDI_REGNUM 5 #define EFLAGS_REGNUM 17 #define XMM1_REGNUM 35 =20=20 /* x86_64_register_raw_size_table[i] is the number of bytes of storage in GDB's register array occupied by register i. */ ! int x86_64_register_raw_size_table[X86_64_NUM_REGS] =3D { ! 8, 8, 8, 8, ! 8, 8, 8, 8, ! 8, 8, 8, 8, ! 8, 8, 8, 8, ! 8, 4, ! 10, 10, 10, 10, ! 10, 10, 10, 10, ! 4, 4, 4, 4, ! 4, 4, 4, 4, ! 16, 16, 16, 16, ! 16, 16, 16, 16, ! 16, 16, 16, 16, ! 16, 16, 16, 16, ! 4 }; =20=20 /* Number of bytes of storage in the actual machine representation for register REGNO. */ int x86_64_register_raw_size (int regno) { ! return x86_64_register_raw_size_table[regno]; } =20=20 /* x86_64_register_byte_table[i] is the offset into the register file of = the start of register number i. We initialize this from ! x86_64_register_raw_size_table. */ int x86_64_register_byte_table[X86_64_NUM_REGS]; =20=20 /* Index within `registers' of the first byte of the space for register R= EGNO. */ --- 35,132 ---- =20=20 /* Register numbers of various important registers. */ #define RAX_REGNUM 0 ! #define RDX_REGNUM 3 #define RDI_REGNUM 5 #define EFLAGS_REGNUM 17 #define XMM1_REGNUM 35 =20=20 + struct register_info {=20 + int size; + char *name; + struct type **type; + }; +=20 /* x86_64_register_raw_size_table[i] is the number of bytes of storage in GDB's register array occupied by register i. */ ! static struct register_info x86_64_register_info_table[] =3D { ! { 8, "rax", &builtin_type_int64 }, ! { 8, "rbx", &builtin_type_int64 }, ! { 8, "rcx", &builtin_type_int64 }, ! { 8, "rdx", &builtin_type_int64 }, ! { 8, "rsi", &builtin_type_int64 }, ! { 8, "rdi", &builtin_type_int64 }, ! { 8, "rbp", &builtin_type_void_func_ptr }, ! { 8, "rsp", &builtin_type_void_func_ptr }, ! { 8, "r8", &builtin_type_int64 }, ! { 8, "r9", &builtin_type_int64 }, ! { 8, "r10", &builtin_type_int64 }, ! { 8, "r11", &builtin_type_int64 }, ! { 8, "r12", &builtin_type_int64 }, ! { 8, "r13", &builtin_type_int64 }, ! { 8, "r14", &builtin_type_int64 }, ! { 8, "r15", &builtin_type_int64 }, ! { 8, "rip", &builtin_type_void_func_ptr }, ! { 4, "eflags", &builtin_type_int32 }, ! { 4, "ds", &builtin_type_int32 }, ! { 4, "es", &builtin_type_int32 }, ! { 4, "fs", &builtin_type_int32 }, ! { 4, "gs", &builtin_type_int32 }, ! { 10, "st0", &builtin_type_i387_ext }, ! { 10, "st1", &builtin_type_i387_ext }, ! { 10, "st2", &builtin_type_i387_ext }, ! { 10, "st3", &builtin_type_i387_ext }, ! { 10, "st4", &builtin_type_i387_ext }, ! { 10, "st5", &builtin_type_i387_ext }, ! { 10, "st6", &builtin_type_i387_ext }, ! { 10, "st7", &builtin_type_i387_ext }, ! { 4, "fctrl", &builtin_type_int32 }, ! { 4, "fstat", &builtin_type_int32 }, ! { 4, "ftag", &builtin_type_int32 }, ! { 4, "fiseg", &builtin_type_int32 }, ! { 4, "fioff", &builtin_type_int32 }, ! { 4, "foseg", &builtin_type_int32 }, ! { 4, "fooff", &builtin_type_int32 }, ! { 4, "fop", &builtin_type_int32 }, ! { 16, "xmm0", &builtin_type_v4sf }, ! { 16, "xmm1", &builtin_type_v4sf }, ! { 16, "xmm2", &builtin_type_v4sf }, ! { 16, "xmm3", &builtin_type_v4sf }, ! { 16, "xmm4", &builtin_type_v4sf }, ! { 16, "xmm5", &builtin_type_v4sf }, ! { 16, "xmm6", &builtin_type_v4sf }, ! { 16, "xmm7", &builtin_type_v4sf }, ! { 16, "xmm8", &builtin_type_v4sf }, ! { 16, "xmm9", &builtin_type_v4sf }, ! { 16, "xmm10", &builtin_type_v4sf }, ! { 16, "xmm11", &builtin_type_v4sf }, ! { 16, "xmm12", &builtin_type_v4sf }, ! { 16, "xmm13", &builtin_type_v4sf }, ! { 16, "xmm14", &builtin_type_v4sf }, ! { 16, "xmm15", &builtin_type_v4sf }, ! { 4, "mxcsr", &builtin_type_int32 } }; =20=20 + /* Number of all registers */ + #define X86_64_NUM_REGS (sizeof (x86_64_register_info_table) / \ + sizeof (x86_64_register_info_table[0])) +=20 + /* Number of general registers. */ + #define X86_64_NUM_GREGS (22) +=20 + int x86_64_num_regs =3D X86_64_NUM_REGS; + int x86_64_num_gregs =3D X86_64_NUM_GREGS; +=20 /* Number of bytes of storage in the actual machine representation for register REGNO. */ int x86_64_register_raw_size (int regno) { ! return x86_64_register_info_table[regno].size; } =20=20 /* x86_64_register_byte_table[i] is the offset into the register file of = the start of register number i. We initialize this from ! x86_64_register_info_table. */ int x86_64_register_byte_table[X86_64_NUM_REGS]; =20=20 /* Index within `registers' of the first byte of the space for register R= EGNO. */ *************** x86_64_register_byte (int regno) *** 84,99 **** static struct type * x86_64_register_virtual_type (int regno) { ! if (regno =3D=3D PC_REGNUM || regno =3D=3D SP_REGNUM) ! return builtin_type_void_func_ptr; ! if (IS_FP_REGNUM (regno)) ! return builtin_type_i387_ext; ! if (IS_SSE_REGNUM (regno)) ! return builtin_type_v4sf; ! if (IS_FPU_CTRL_REGNUM (regno) || regno =3D=3D MXCSR_REGNUM ! || regno =3D=3D EFLAGS_REGNUM) ! return builtin_type_int32; ! return builtin_type_int64; } =20=20 /* x86_64_register_convertible is true if register N's virtual format is --- 141,147 ---- static struct type * x86_64_register_virtual_type (int regno) { ! return *x86_64_register_info_table[regno].type; } =20=20 /* x86_64_register_convertible is true if register N's virtual format is *************** x86_64_push_arguments (int nargs, struct *** 557,571 **** int i; static int int_parameter_registers[INT_REGS] =3D { 5 /*RDI*/, 4 /*RSI*/, ! 1 /*RDX*/, 2 /*RCX*/, ! 8 /*R8 */ , 9 /*R9 */ }; /* XMM0 - XMM15 */ static int sse_parameter_registers[SSE_REGS] =3D { ! 34, 35, 36, 37, ! 38, 39, 40, 41, ! 42, 43, 44, 45, ! 46, 47, 48, 49 }; int stack_values_count =3D 0; int *stack_values; --- 605,619 ---- int i; static int int_parameter_registers[INT_REGS] =3D { 5 /*RDI*/, 4 /*RSI*/, ! 3 /*RDX*/, 2 /*RCX*/, ! 8 /*R8 */, 9 /*R9 */ }; /* XMM0 - XMM15 */ static int sse_parameter_registers[SSE_REGS] =3D { ! XMM1_REGNUM-1, XMM1_REGNUM, XMM1_REGNUM+1, XMM1_REGNUM+2,=20 ! XMM1_REGNUM+3, XMM1_REGNUM+4, XMM1_REGNUM+5, XMM1_REGNUM+6,=20 ! XMM1_REGNUM+7, XMM1_REGNUM+8, XMM1_REGNUM+9, XMM1_REGNUM+10,=20 ! XMM1_REGNUM+11, XMM1_REGNUM+12, XMM1_REGNUM+13, XMM1_REGNUM+14 }; int stack_values_count =3D 0; int *stack_values; *************** x86_64_store_return_value (struct type * *** 704,730 **** static char * x86_64_register_name (int reg_nr) { ! static char *register_names[] =3D { ! "rax", "rdx", "rcx", "rbx", ! "rsi", "rdi", "rbp", "rsp", ! "r8", "r9", "r10", "r11", ! "r12", "r13", "r14", "r15", ! "rip", "eflags", ! "st0", "st1", "st2", "st3", ! "st4", "st5", "st6", "st7", ! "fctrl", "fstat", "ftag", "fiseg", ! "fioff", "foseg", "fooff", "fop", ! "xmm0", "xmm1", "xmm2", "xmm3", ! "xmm4", "xmm5", "xmm6", "xmm7", ! "xmm8", "xmm9", "xmm10", "xmm11", ! "xmm12", "xmm13", "xmm14", "xmm15", ! "mxcsr" ! }; ! if (reg_nr < 0) return NULL; ! if (reg_nr >=3D (sizeof (register_names) / sizeof (*register_names))) ! return NULL; ! return register_names[reg_nr]; } =0C =20=20 --- 752,760 ---- static char * x86_64_register_name (int reg_nr) { ! if (reg_nr < 0 || reg_nr >=3D X86_64_NUM_REGS) return NULL; ! return x86_64_register_info_table[reg_nr].name; } =0C =20=20 *************** i386_gdbarch_init (struct gdbarch_info i *** 826,831 **** --- 856,862 ---- { struct gdbarch *gdbarch; struct gdbarch_tdep *tdep; + int i, sum; =20=20 /* Find a candidate among the list of pre-declared architectures. */ for (arches =3D gdbarch_list_lookup_by_info (arches, &info); *************** i386_gdbarch_init (struct gdbarch_info i *** 904,913 **** set_gdbarch_register_raw_size (gdbarch, x86_64_register_raw_size); set_gdbarch_max_register_raw_size (gdbarch, 16); set_gdbarch_register_byte (gdbarch, x86_64_register_byte); /* Total amount of space needed to store our copies of the machine's re= gister (SIZEOF_GREGS + SIZEOF_FPU_REGS + SIZEOF_FPU_CTRL_REGS + SIZEOF_SSE_= REGS) */ ! set_gdbarch_register_bytes (gdbarch, ! (18 * 8) + (8 * 10) + (8 * 4) + (16 * 16 + 4)); set_gdbarch_register_virtual_size (gdbarch, generic_register_virtual_si= ze); set_gdbarch_max_register_virtual_size (gdbarch, 16); =20=20 --- 935,946 ---- set_gdbarch_register_raw_size (gdbarch, x86_64_register_raw_size); set_gdbarch_max_register_raw_size (gdbarch, 16); set_gdbarch_register_byte (gdbarch, x86_64_register_byte); +=20 /* Total amount of space needed to store our copies of the machine's re= gister (SIZEOF_GREGS + SIZEOF_FPU_REGS + SIZEOF_FPU_CTRL_REGS + SIZEOF_SSE_= REGS) */ ! for (i=3D0, sum=3D0; i < X86_64_NUM_REGS; i++) ! sum +=3D x86_64_register_info_table[i].size; ! set_gdbarch_register_bytes (gdbarch, sum); set_gdbarch_register_virtual_size (gdbarch, generic_register_virtual_si= ze); set_gdbarch_max_register_virtual_size (gdbarch, 16); =20=20 *************** i386_gdbarch_init (struct gdbarch_info i *** 924,930 **** set_gdbarch_fp_regnum (gdbarch, 6); /* (rbp) */ set_gdbarch_pc_regnum (gdbarch, 16); /* (rip) Contains program counter.= */ =20=20 ! set_gdbarch_fp0_regnum (gdbarch, 18); /* First FPU floating-point regis= ter. */ =20=20 set_gdbarch_read_fp (gdbarch, cfi_read_fp); set_gdbarch_write_fp (gdbarch, cfi_write_fp); --- 957,963 ---- set_gdbarch_fp_regnum (gdbarch, 6); /* (rbp) */ set_gdbarch_pc_regnum (gdbarch, 16); /* (rip) Contains program counter.= */ =20=20 ! set_gdbarch_fp0_regnum (gdbarch, X86_64_NUM_GREGS); /* First FPU floati= ng-point register. */ =20=20 set_gdbarch_read_fp (gdbarch, cfi_read_fp); set_gdbarch_write_fp (gdbarch, cfi_write_fp); *************** _initialize_x86_64_tdep (void) *** 1042,1048 **** for (i =3D 0; i < X86_64_NUM_REGS; i++) { x86_64_register_byte_table[i] =3D offset; ! offset +=3D x86_64_register_raw_size_table[i]; } } =20=20 --- 1075,1081 ---- for (i =3D 0; i < X86_64_NUM_REGS; i++) { x86_64_register_byte_table[i] =3D offset; ! offset +=3D x86_64_register_info_table[i].size; } } =20=20 Index: x86-64-tdep.h =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/x86-64-tdep.h,v retrieving revision 1.2 diff -c -3 -p -r1.2 x86-64-tdep.h *** x86-64-tdep.h 2002/03/10 18:16:26 1.2 --- x86-64-tdep.h 2002/03/26 16:56:52 *************** *** 25,35 **** =20=20 #include "i386-tdep.h" =20=20 ! /* Number of all registers */ ! #define X86_64_NUM_REGS (51) !=20 ! /* Number of general registers. */ ! #define X86_64_NUM_GREGS (18) =20=20 gdbarch_frame_saved_pc_ftype x86_64_linux_frame_saved_pc; gdbarch_saved_pc_after_call_ftype x86_64_linux_saved_pc_after_call; --- 25,32 ---- =20=20 #include "i386-tdep.h" =20=20 ! extern int x86_64_num_regs; ! extern int x86_64_num_gregs; =20=20 gdbarch_frame_saved_pc_ftype x86_64_linux_frame_saved_pc; gdbarch_saved_pc_after_call_ftype x86_64_linux_saved_pc_after_call; Index: x86-64-linux-nat.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/x86-64-linux-nat.c,v retrieving revision 1.6 diff -c -3 -p -r1.6 x86-64-linux-nat.c *** x86-64-linux-nat.c 2002/03/10 18:16:26 1.6 --- x86-64-linux-nat.c 2002/03/26 16:56:52 *************** *** 39,49 **** format and GDB's register array layout. */ =20=20 static int x86_64_regmap[] =3D { ! RAX, RDX, RCX, RBX, RSI, RDI, RBP, RSP, R8, R9, R10, R11, R12, R13, R14, R15, ! RIP, EFLAGS }; =20=20 static unsigned long --- 39,50 ---- format and GDB's register array layout. */ =20=20 static int x86_64_regmap[] =3D { ! RAX, RBX, RCX, RDX, RSI, RDI, RBP, RSP, R8, R9, R10, R11, R12, R13, R14, R15, ! RIP, EFLAGS,=20 ! DS, ES, FS, GS }; =20=20 static unsigned long *************** x86_64_linux_dr_get_status (void) *** 125,131 **** the register sets used by `ptrace'. */ =20=20 #define GETREGS_SUPPLIES(regno) \ ! (0 <=3D (regno) && (regno) <=3D 17) #define GETFPREGS_SUPPLIES(regno) \ (FP0_REGNUM <=3D (regno) && (regno) <=3D MXCSR_REGNUM) =20=20 --- 126,132 ---- the register sets used by `ptrace'. */ =20=20 #define GETREGS_SUPPLIES(regno) \ ! (0 <=3D (regno) && (regno) < x86_64_num_gregs) #define GETFPREGS_SUPPLIES(regno) \ (FP0_REGNUM <=3D (regno) && (regno) <=3D MXCSR_REGNUM) =20=20 *************** supply_gregset (elf_gregset_t * gregsetp *** 144,150 **** elf_greg_t *regp =3D (elf_greg_t *) gregsetp; int i; =20=20 ! for (i =3D 0; i < X86_64_NUM_GREGS; i++) supply_register (i, (char *) (regp + x86_64_regmap[i])); } =20=20 --- 145,151 ---- elf_greg_t *regp =3D (elf_greg_t *) gregsetp; int i; =20=20 ! for (i =3D 0; i < x86_64_num_gregs; i++) supply_register (i, (char *) (regp + x86_64_regmap[i])); } =20=20 *************** fill_gregset (elf_gregset_t * gregsetp,=20 *** 158,164 **** elf_greg_t *regp =3D (elf_greg_t *) gregsetp; int i; =20=20 ! for (i =3D 0; i < X86_64_NUM_GREGS; i++) if ((regno =3D=3D -1 || regno =3D=3D i)) read_register_gen (i, regp + x86_64_regmap[i]); } --- 159,165 ---- elf_greg_t *regp =3D (elf_greg_t *) gregsetp; int i; =20=20 ! for (i =3D 0; i < x86_64_num_gregs; i++) if ((regno =3D=3D -1 || regno =3D=3D i)) read_register_gen (i, regp + x86_64_regmap[i]); } --------------060801040502030600010700--