From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5174 invoked by alias); 26 Mar 2002 17:27:24 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5167 invoked from network); 26 Mar 2002 17:27:24 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 26 Mar 2002 17:27:24 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 271483EDA; Tue, 26 Mar 2002 12:25:40 -0500 (EST) Message-ID: <3CA0AF14.8050801@cygnus.com> Date: Tue, 26 Mar 2002 09:27:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.8) Gecko/20020210 X-Accept-Language: en-us MIME-Version: 1.0 To: Daniel Berlin Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Let dwarf2 CFI's execute_stack_op be used outside of CFI References: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-03/txt/msg00492.txt.bz2 > On Mon, 25 Mar 2002, Andrew Cagney wrote: > > >> > This patch simply adds an external entry point (dwarf2_execute_stack_op), >> > that doesn't require the CFA context. It also adds code so that when the >> > context passed to execute_stack_op is NULL, we use read_register_gen to >> > get registers. > >> >> Hmm, where are you going here? > > > Um, rather than have multiple dwarf2 stack op executors, have one. > In order to do this, it needs to not require CFA context to be able to > read registers. Shouldn't the dwarf2 location expression evaluator be separated out (dwarf2loc?) and be parameterized with both the frame it is to operate within and the expression it is to evaluate. If the expression evaluator needs the value of a register from the frame it just calls whatever the frame-get-reg-value(frame) function is. Andrew