Re: [RFA] x86_64_skip_prologue

[Michal Ludvig <mludvig@suse.cz>]

Michal Ludvig wrote:
> Kevin Buettner wrote:
> 
>>> 3) Now pc points to the first line of the sourcecode of the function 
>>> (usually opening '{'). If the next line with debuginfo has pc within 
>>> bounds of this function, we will return this pc instead.
>> You might want to take a look at some of the other prologue analyzers.
>> In particular, you might want to consider calling find_pc_line() instead
>> of accessing the data structures directly.
> Most of other *_skip_prologue functions pretend, that prolog is an 
> always-the-same sequence of instructions, what is not the case on 
> x86-64. I can't see an approach other than the one I have chosen.
> Of course I can use other structures and maybe some macros, but the 
> concept will remain. Or is there another way?
> 
> Why should I preferably use find_pc_line()? It gives me the same symtab 
> as find_pc_symtab() does... Anyway I have rewritten the code to use it.

Any comments, complains, suggestions, whatever? Can I commit?
Michal Ludvig
-- 
* SuSE CR, s.r.o     * mludvig@suse.cz
* +420 2 9654 5373   * http://www.suse.cz