Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Joel Brobecker <brobecker@ACT-Europe.FR>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] gdb_realpath causes problems with GVD
Date: Tue, 19 Mar 2002 10:29:00 -0000	[thread overview]
Message-ID: <3C978395.9040306@cygnus.com> (raw)
In-Reply-To: <20020319171236.D6465@act-europe.fr>

Joel,

I suspect you're right.

Two comments:

I think gdb_realpath() needs a re-name - it no longer implements 
realpath() semantics.  xfullpath() comes to mind (`x' for `xmalloc', 
`fullpath' cos it is close to realpath :-) (Better ideas? Does libiberty 
already provide an equivalent?)

I don't think trying to rewriting the gdb_realpath() autoconfigury magic 
is a good idea (the rewrite as two comile errors).  Instead just assume 
that gdb_realpath() works and use that, concat() and xfree().  I think 
the first rule of autoconf is, if it ain't `broke' don't fix it :-)(1)

enjoy,
Andrew

(1) Yes, I know, I've got that NULL canonicalize patch to commit :-)


  parent reply	other threads:[~2002-03-19 18:29 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-03-19  8:12 Joel Brobecker
2002-03-19  9:17 ` Eli Zaretskii
2002-03-19  9:34   ` Daniel Jacobowitz
2002-03-19  9:56     ` Joel Brobecker
2002-03-19 11:18     ` Eli Zaretskii
2002-03-19 12:14       ` Joel Brobecker
2002-03-19 22:04         ` Eli Zaretskii
2002-03-20  1:15           ` Joel Brobecker
2002-03-20  3:12             ` Eli Zaretskii
2002-03-20  4:05               ` Joel Brobecker
2002-03-20 10:25                 ` Eli Zaretskii
2002-03-20  8:10               ` Andrew Cagney
2002-03-20  9:41                 ` Joel Brobecker
2002-03-19 10:29 ` Andrew Cagney [this message]
2002-03-19 14:28   ` Joel Brobecker
2002-03-20 14:16 ` Tom Tromey
2002-03-21  0:11   ` Joel Brobecker
2002-03-21  3:44     ` Joel Brobecker
2002-03-23 21:35       ` Tom Tromey
2002-03-25  1:22         ` Joel Brobecker
2002-03-25  9:23           ` Tom Tromey
2002-03-25 10:01             ` Joel Brobecker
2002-03-27 19:36               ` Andrew Cagney
2002-03-27 19:42                 ` Daniel Jacobowitz
2002-03-23 21:13     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C978395.9040306@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=brobecker@ACT-Europe.FR \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox