From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21025 invoked by alias); 18 Mar 2002 16:37:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20962 invoked from network); 18 Mar 2002 16:36:57 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 18 Mar 2002 16:36:57 -0000 Received: from redhat.com (rtl.cygnus.com [205.180.230.21]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id IAA15808; Mon, 18 Mar 2002 08:36:55 -0800 (PST) Message-ID: <3C96173E.3879600B@redhat.com> Date: Mon, 18 Mar 2002 08:37:00 -0000 From: Fernando Nasser Organization: Red Hat Canada X-Mailer: Mozilla 4.78 [en] (X11; U; Linux 2.4.9-21 i686) X-Accept-Language: en MIME-Version: 1.0 To: Andrew Cagney CC: gdb-patches@sources.redhat.com Subject: Re: [rfc/cli:rfa] Don't copy func() into show from set .. References: <3C953AF0.7040504@cygnus.com> <3C960F4F.B356B226@redhat.com> <3C9616D3.3060300@cygnus.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-03/txt/msg00312.txt.bz2 Andrew Cagney wrote: > > > Andrew, I agree with all that you say before but I have some > > additional thoughts. > > I'll leave it for a week then commit it (if that is ok) ..... > Sure. > > Should we ever allow for the creation of a set command without > > a show? If not, we should get rid of add_set_cmd() and > > add_show_from_set() and have a single add_setshow_cmd(). > > This would prevent anyone of creating a set without the > > corresponding show and hide the implementation details. > > That's true. > > > It could return the show pointer as an argument if so requested. > > Ah, yes! You're thinking of > > set = add_setshow_cmd (name, class, ..., &show); > > where the &show could be NULL. > > I can add it, and ARI (just info) the other versions, if you want. > If you can, please do it. Thank you very much for the fix and clean-up. -- Fernando Nasser Red Hat Canada Ltd. E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9