Re: [rfa] Add -m; Was: ARM sim patch: increase default target memory

Nick Clifton
2002-04-08T09:34:42Z

Hi Andrew,

> The attatched patch (er, hack), adds support for the -m flag from
> the GDB command line (vis (gdb) target sim -m<size>).

Hmm, this looks generally OK to me, except that I would recommend
using "strtoul" instead of "atoi" to convert the string into a
number, so that hex values can be specified as well as decimal. I
would also suggest that you consider adding support for a megabyte
postfix so that the user could do:

-m 6M

to set up a 6 megabyte virtual memory, instead of having to type:

-m 6291456

> It also sets the default memory size back to something consistent
> with the other simulators.

This will stop the java tests from running, so maybe you should also
add the new switch to the java test harness so that they do not fail.

Cheers
Nick