From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-13293-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 17528 invoked by alias); 10 Mar 2002 20:16:04 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 17466 invoked from network); 10 Mar 2002 20:16:02 -0000
Received: from unknown (HELO localhost.redhat.com) (24.112.135.44)
  by sources.redhat.com with SMTP; 10 Mar 2002 20:16:02 -0000
Received: from cygnus.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id BDC8A3CA9; Sun, 10 Mar 2002 15:15:56 -0500 (EST)
Message-ID: <3C8BBEFC.5040504@cygnus.com>
Date: Sun, 10 Mar 2002 12:16:00 -0000
From: Andrew Cagney <ac131313@cygnus.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.8) Gecko/20020210
X-Accept-Language: en-us
MIME-Version: 1.0
To: Michal Ludvig <mludvig@suse.cz>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] remote debugging patches
References: <3C8BA71F.20807@suse.cz>
Content-Type: text/plain; charset=ISO-8859-2; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-03/txt/msg00145.txt.bz2

Michal, as an aside, these are independant changes, it is really helpful 
if they are submitted separatly (making review much easier).

    * remote.c: Added WAIT_FOREVER_FLAG and changed all
     calls to getpkt() to respect it.

> +#define WAIT_FOREVER_FLAG 0

Yes fine, er almost.  Can you change the name of this to 
``DONT_WAIT_FOREVER_FLAG'' and suggest making it an enum. (so GDB can 
print it :-)

If you're feeling really inspired (...), you could even introduce an 
enum to handle both the DO and DONT cases.

Andrew