Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: Don Howard <dhoward@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA] mips: Fix "info registers" output
Date: Sun, 10 Mar 2002 09:46:00 -0000	[thread overview]
Message-ID: <3C8B9C06.9020506@cygnus.com> (raw)
In-Reply-To: <20020310120037.A29124@nevyn.them.org>

> On Sun, Mar 10, 2002 at 11:30:09AM -0500, Andrew Cagney wrote:

>> Suggest a FIXME and bug report here.  It isn't safe to assume things 
>> like builtin_type_double is 64 bit.  The code should use the ABI 
>> independant builtin_type_ieee_BLAH.  But this is a separate bug and not 
>> your problem :-)
> 
> 
> builtin_type_double =
>     init_type (TYPE_CODE_FLT, TARGET_DOUBLE_BIT / TARGET_CHAR_BIT,
>                0,
>                "double", (struct objfile *) NULL);
> 
> 
>   set_gdbarch_double_bit (gdbarch, 64);
> 
> 
> Why isn't it safe to assume that a double is 64-bit when we explicitly
> set it that way?  I assume that the builtin types get swapped out when
> we change gdbarch... yes, they do.  Besides, is MIPS FP actually IEEE? 
> Oh, I suppose the values probably are and only some of the math isn't.

Have a look at GCC's -fshort-double option.  I'm not sure how MIPS would 
respond to it but I suspect it would make everyones head hurt. :-)

The ``info registers'' code is both ISA and ABI dependant.  ISA since 
that determines the raw format of registers (ieee_double_{big,little} 
not double) - the ABI shouldn't change a MIPS DOUBLE.  ABI since that 
determins where bits of registers end up being saved on the stack.

> Committed without that last FIXME; I'll add it if it's really
> necessary
Er, where's the fire?  With all respect, it is always better to give the 
other party the chance to respond.

Andrew



  reply	other threads:[~2002-03-10 17:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20010619225007.A10141@nevyn.them.org>
2001-06-20  7:19 ` Andrew Cagney
2001-06-21  0:45 ` Eli Zaretskii
2001-06-21  8:37   ` Daniel Jacobowitz
2001-06-21  9:29     ` Eli Zaretskii
2001-06-21  9:44       ` Daniel Jacobowitz
2001-06-21 12:00         ` Eli Zaretskii
2001-06-21 13:12           ` Daniel Jacobowitz
2001-06-21 14:22           ` Don Howard
2002-03-07 13:59 ` Daniel Jacobowitz
2002-03-09 18:05   ` Andrew Cagney
2002-03-09 22:58     ` Daniel Jacobowitz
2002-03-10  8:30       ` Andrew Cagney
2002-03-10  9:00         ` Daniel Jacobowitz
2002-03-10  9:46           ` Andrew Cagney [this message]
2002-03-10 11:30             ` Daniel Jacobowitz
2002-03-10 12:45               ` Andrew Cagney
2002-03-10 14:26                 ` Daniel Jacobowitz
2002-03-10 15:18                   ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C8B9C06.9020506@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=dhoward@redhat.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox