From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-13277-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 16376 invoked by alias); 10 Mar 2002 03:12:09 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 16238 invoked from network); 10 Mar 2002 03:12:07 -0000
Received: from unknown (HELO localhost.redhat.com) (24.112.135.44)
  by sources.redhat.com with SMTP; 10 Mar 2002 03:12:07 -0000
Received: from cygnus.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 1CF003E0B; Sat,  9 Mar 2002 22:12:07 -0500 (EST)
Message-ID: <3C8ACF07.3060906@cygnus.com>
Date: Sat, 09 Mar 2002 19:12:00 -0000
From: Andrew Cagney <ac131313@cygnus.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.8) Gecko/20020210
X-Accept-Language: en-us
MIME-Version: 1.0
To: Klee Dienes <kdienes@apple.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] Allow '!' in program paths
References: <F7C3F3F9-1B5B-11D6-8F8D-0030653FA4C6@apple.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-03/txt/msg00129.txt.bz2

Dig dig.  Yes, thanks (sorry for the delay).

Andrew



> 2002-02-06  Klee Dienes  <klee@apple.com>
> 
>         * fork-inferior.c (fork_inferior): Add '!' to the list of
>         characters that need to be quoted when building a string for the
>         shell.  Quote '!' specifically with a backslash, since CSH chokes
>         when trying to evaluate "str!str".
> 
> Index: fork-child.c
> ===================================================================
> RCS file: /cvs/Darwin/Commands/GNU/cygnus/src/gdb/fork-child.c,v
> retrieving revision 1.9
> diff -u -r1.9 fork-child.c
> --- fork-child.c        2001/11/29 00:18:44     1.9
> +++ fork-child.c        2002/02/06 22:53:11
> @@ -204,6 +204,7 @@
>           switch (*p)
>             {
>             case '\'':
> +           case '!':
>             case '"':
>             case '(':
>             case ')':
> @@ -235,6 +236,8 @@
>             {
>               if (*p == '\'')
>                 strcat (shell_command, "'\\''");
> +             else if (*p == '!')
> +               strcat (shell_command, "\\!");
>               else
>                 strncat (shell_command, p, 1);
>             }
>