From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12180 invoked by alias); 4 Mar 2002 18:08:05 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12043 invoked from network); 4 Mar 2002 18:07:57 -0000 Received: from unknown (HELO kerberos.suse.cz) (195.47.106.10) by sources.redhat.com with SMTP; 4 Mar 2002 18:07:57 -0000 Received: from chimera.suse.cz (chimera.suse.cz [10.20.0.2]) by kerberos.suse.cz (SuSE SMTP server) with ESMTP id 5882859D35D for ; Mon, 4 Mar 2002 19:07:56 +0100 (CET) Received: from suse.cz (leviathan.suse.cz [10.20.1.56]) by chimera.suse.cz (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id g24I7uN15972 for ; Mon, 4 Mar 2002 19:07:56 +0100 X-Authentication-Warning: chimera.suse.cz: Host leviathan.suse.cz [10.20.1.56] claimed to be suse.cz Message-ID: <3C83B7FC.9030803@suse.cz> Date: Mon, 04 Mar 2002 10:08:00 -0000 From: Michal Ludvig Organization: SuSE CR User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.8) Gecko/20020204 X-Accept-Language: cs, cz, en MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: Re: [RFA] Crossdebugging compilation fix for x86-64 References: <3C8368C6.90101@suse.cz> <20020304112017.A19528@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-03/txt/msg00034.txt.bz2 Andreas Schwab wrote: > What puzzles me more is the fact that x86_64_regmap is defined (and not > just declared) in a header. It is only used in x86-64-linux-nat.c, so it > should be moved there (and that file can use freely). I already did this change in my tree and will post a patch for approval tomorrow. And what about these declarations: gdbarch_frame_saved_pc_ftype x86_64_linux_frame_saved_pc; gdbarch_saved_pc_after_call_ftype x86_64_linux_saved_pc_after_call; Shouldn't they go away from the header as well, so that only #defines will remain there as on other architectures? Michal Ludvig -- * SuSE CR, s.r.o * mludvig@suse.cz * +420 2 9654 5373 * http://www.suse.cz