From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21888 invoked by alias); 4 Mar 2002 11:07:05 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21773 invoked from network); 4 Mar 2002 11:07:00 -0000 Received: from unknown (HELO kerberos.suse.cz) (195.47.106.10) by sources.redhat.com with SMTP; 4 Mar 2002 11:07:00 -0000 Received: from chimera.suse.cz (chimera.suse.cz [10.20.0.2]) by kerberos.suse.cz (SuSE SMTP server) with ESMTP id 97C9F59D35D for ; Mon, 4 Mar 2002 12:06:59 +0100 (CET) Received: from suse.cz (leviathan.suse.cz [10.20.1.56]) by chimera.suse.cz (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id g24B6xN00631 for ; Mon, 4 Mar 2002 12:06:59 +0100 X-Authentication-Warning: chimera.suse.cz: Host leviathan.suse.cz [10.20.1.56] claimed to be suse.cz Message-ID: <3C835553.4080201@suse.cz> Date: Mon, 04 Mar 2002 03:07:00 -0000 From: Michal Ludvig Organization: SuSE CR User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.8) Gecko/20020204 X-Accept-Language: cs, cz, en MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: Re: [RFA] Bugfixes on x86-64 target References: <3C7F9777.4070009@cygnus.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-03/txt/msg00023.txt.bz2 Andrew Cagney wrote: > Michal, > Can I suggest adding your self to the maintainers file as an obvious fix > (don't forget to post the patch). Index: ChangeLog from Michal Ludvig * MAINTAINERS (x86-64): Add myself. Index: MAINTAINERS =================================================================== RCS file: /cvs/src/src/gdb/MAINTAINERS,v retrieving revision 1.154 diff -c -3 -p -r1.154 MAINTAINERS *** MAINTAINERS 2002/03/01 03:30:59 1.154 --- MAINTAINERS 2002/03/04 10:54:48 *************** maintainer works with the native maintai *** 171,177 **** w65 Deleted. x86-64 (--target=x86_64-linux-gnu broken) ! Maintenance only xstormy16 --target=xstormy16-elf ,-Werror Corinna Vinschen vinschen@redhat.com --- 171,177 ---- w65 Deleted. x86-64 (--target=x86_64-linux-gnu broken) ! Michal Ludvig mludvig@suse.cz xstormy16 --target=xstormy16-elf ,-Werror Corinna Vinschen vinschen@redhat.com > You may also want to tweak x86-64 as it uses value_ptr which no longer > exists. >> + value_ptr arg = args[stack_values[stack_values_count]]; > ARI spotted it :-) This was fixed in the second (corrected) posting of my patch. Unfortunately you've commited the broken one :-( Anyway, patch follows... Index: ChangeLog from Michal Ludvig * x86-64-tdep.c (x86_64_push_arguments): Fixed typo naregs->nregs, changed value_ptr -> struct value * Index: x86-64-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/x86-64-tdep.c,v retrieving revision 1.9 diff -c -3 -p -r1.9 x86-64-tdep.c *** x86-64-tdep.c 2002/02/27 02:55:13 1.9 --- x86-64-tdep.c 2002/03/04 10:54:49 *************** x86_64_push_arguments (int nargs, struct *** 569,575 **** }; int stack_values_count = 0; int *stack_values; ! stack_values = alloca (naregs * sizeof (int)); for (i = 0; i < nargs; i++) { enum x86_64_reg_class class[MAX_CLASSES]; --- 569,575 ---- }; int stack_values_count = 0; int *stack_values; ! stack_values = alloca (nargs * sizeof (int)); for (i = 0; i < nargs; i++) { enum x86_64_reg_class class[MAX_CLASSES]; *************** x86_64_push_arguments (int nargs, struct *** 639,645 **** } while (--stack_values_count >= 0) { ! value_ptr arg = args[stack_values[stack_values_count]]; int len = TYPE_LENGTH (VALUE_ENCLOSING_TYPE (arg)); len += 7; len -= len % 8; --- 639,645 ---- } while (--stack_values_count >= 0) { ! struct value *arg = args[stack_values[stack_values_count]]; int len = TYPE_LENGTH (VALUE_ENCLOSING_TYPE (arg)); len += 7; len -= len % 8; Both patches are commited as obvious fixes. Michal Ludvig -- * SuSE CR, s.r.o * mludvig@suse.cz * +420 2 9654 5373 * http://www.suse.cz