From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-13160-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 947 invoked by alias); 2 Mar 2002 23:01:37 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 826 invoked from network); 2 Mar 2002 23:01:34 -0000
Received: from unknown (HELO cygnus.com) (205.180.230.5)
  by sources.redhat.com with SMTP; 2 Mar 2002 23:01:34 -0000
Received: from telocity.telocity.com (taarna.cygnus.com [205.180.230.102])
	by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with SMTP id PAA25892;
	Sat, 2 Mar 2002 15:01:29 -0800 (PST)
Message-ID: <3C81587B.22C2@redhat.com>
Date: Sat, 02 Mar 2002 15:01:00 -0000
From: Michael Snyder <msnyder@redhat.com>
X-Mailer: Mozilla 3.04 (Win95; I)
MIME-Version: 1.0
To: fnf@redhat.com
CC: gdb-patches@sources.redhat.com
Subject: Re: [RFC] xfail a break.exp test for remote targets
References: <200203021910.g22JA8P04673@fred.ninemoons.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-03/txt/msg00012.txt.bz2

Fred Fish wrote:
> 
> I just posted a fairly long analysis to the gdb-bug list about how
> remote targets can miss breakpoints internal to a line or fail to
> print the breakpoint info for a breakpoint at the end of a stepping
> range, when single stepping over a source line.  This patch will fix
> the testsuite failure until the remote/native difference in resuming
> execution in the single step case can be resolved.
> 
> Comments?

No, just disable the 'e' packet -- it's broken.

> 
> -Fred
> 
> 2002-03-02  Fred Fish  <fnf@redhat.com>
> 
>         * gdb.base/break.exp: Setup xfail for remote targets for the
>         "step onto breakpoint" due to the way remote targets handle
>         breakpoints at the end of a stepping range.
> 
> Index: gdb.base/break.exp
> ===================================================================
> RCS file: /cvs/cvsfiles/devo/gdb/testsuite/gdb.base/break.exp,v
> retrieving revision 1.65
> diff -c -p -r1.65 break.exp
> *** break.exp   2002/01/13 00:32:27     1.65
> --- break.exp   2002/03/02 18:50:04
> *************** gdb_test "break +1" \
> *** 222,227 ****
> --- 222,237 ----
> 
>   # Check to see if breakpoint is hit when stepped onto
> 
> + # This will always fail for remote targets that step over the entire
> + # source line in one operation local to the target because gdb won't
> + # have breakpoints inserted for the first single step and thus won't
> + # print the breakpoint at the location it stops at after stepping.
> + # Note that removing the current stopped-at breakpoint (number 5) would
> + # cause this test to succeed.  Perhaps we should try it both ways.
> + if [is_remote target] {
> +     setup_xfail "*-*-*"
> + }
> +
>   gdb_test "step" \
>       ".*Breakpoint \[0-9\]+, main \\(argc=.*, argv=.*, envp=.*\\) at .*$srcfile:86.*86\[\t \]+return argc;" \
>       "step onto breakpoint"