From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6373 invoked by alias); 25 Feb 2002 00:42:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6133 invoked from network); 25 Feb 2002 00:42:21 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 25 Feb 2002 00:42:21 -0000 Received: from telocity.telocity.com (taarna.cygnus.com [205.180.230.102]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with SMTP id QAA14374; Sun, 24 Feb 2002 16:42:16 -0800 (PST) Message-ID: <3C798723.4D4B@redhat.com> Date: Sun, 24 Feb 2002 16:42:00 -0000 From: Michael Snyder X-Mailer: Mozilla 3.04 (Win95; I) MIME-Version: 1.0 To: Andrew Cagney CC: gdb-patches@sources.redhat.com Subject: Re: [patch/rfc] Disable [eE] packets by default References: <3C79867F.3000906@cygnus.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-02/txt/msg00690.txt.bz2 Andrew Cagney wrote: > > Hello, > > This is a followup to the current discussion regarding the [Ee] packets. > It disables them by default. > > While it is a brutal solution to a problem, it is also 6 days before 5.2 > branches. It also clears the slate for another attempt at this. > > Thoughts? I think this is the right thing to do. Previously we had no way to test the 'e' packet. Now that we do have, it is seen to be buggy. This is like an unreliable optimization. You can give the user the opportunity to use it if he chooses, but you don't turn it on by default. I would like to start discussing the right way to implement this. For one thing, the current implementation has remote.c snatching control away from infrun, and doing something completely different from what infrun asked it to do. I'd like to have the decision about whether to use step-over-range made in infrun, not in the target layer. > Andrew > > PS: There is no doco patch. This packet was never documented. Sigh :-( > > --------------------------------------------------------------- > 2002-02-24 Andrew Cagney > > * remote.c (_initialize_remote): By default, disable ``e'' and > ``E'' step out-of-range packets. > > Index: remote.c > =================================================================== > RCS file: /cvs/src/src/gdb/remote.c,v > retrieving revision 1.76 > diff -u -r1.76 remote.c > --- remote.c 2002/02/10 04:08:42 1.76 > +++ remote.c 2002/02/25 00:19:23 > @@ -6099,6 +6099,10 @@ > show_remote_protocol_e_packet_cmd, > &remote_set_cmdlist, &remote_show_cmdlist, > 0); > + /* Disable by default. The ``e'' packet has nasty interactions with > + the threading code - it relies on global state. */ > + remote_protocol_e.detect = CMD_AUTO_BOOLEAN_FALSE; > + update_packet_config (&remote_protocol_e); > > add_packet_config_cmd (&remote_protocol_E, > "E", "step-over-range-w-signal", > @@ -6106,6 +6110,10 @@ > show_remote_protocol_E_packet_cmd, > &remote_set_cmdlist, &remote_show_cmdlist, > 0); > + /* Disable by default. The ``e'' packet has nasty interactions with > + the threading code - it relies on global state. */ > + remote_protocol_E.detect = CMD_AUTO_BOOLEAN_FALSE; > + update_packet_config (&remote_protocol_E); > > add_packet_config_cmd (&remote_protocol_P, > "P", "set-register",