From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17984 invoked by alias); 24 Feb 2002 17:12:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17954 invoked from network); 24 Feb 2002 17:12:58 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.135.44) by sources.redhat.com with SMTP; 24 Feb 2002 17:12:58 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 44C6D3D51; Sun, 24 Feb 2002 12:12:56 -0500 (EST) Message-ID: <3C791F18.90209@cygnus.com> Date: Sun, 24 Feb 2002 09:12:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.8) Gecko/20020210 X-Accept-Language: en-us MIME-Version: 1.0 To: Jim Blandy Cc: tromey@redhat.com, gdb-patches@sources.redhat.com Subject: Re: Patch: Dwarf2 reader -vs- DW_OP_piece References: <87664qej9l.fsf@creche.redhat.com> <87zo22ctbq.fsf@creche.redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-02/txt/msg00675.txt.bz2 > That makes sense. > > Could you change your patch to detect that pattern, verify that the > register numbers are consecutive (according to DWARF2_REG_TO_REGNUM), > return the number of the first register if everything seems right, and > give a dwarf2_complex_location_expr complaint otherwise? > > This is a bit more work, but it's more correct. BTW, this assumption is one of the two origins of our good friend (not) read_register_bytes(). Sigh. Andrew