[RFA #2] gdb.threads/linux-dp.c: accommodate gcc 3.1

Michael Elizabeth Chastain
2002-02-23T22:46:44Z

This is RFA #2 for this patch.

gcc HEAD has a new warning:

warning: no return statement in function returning non-void

Unfortunately this breaks code in gdb.threads/linux-dp.c:

void *
philosopher (void *data)
{
...
for (;;)
{
...
}
}

I consider this to be a bug in gcc HEAD, and I've filed PR gcc/5725.

Meanwhile, I would like to change linux-dp.c so that it compiles.
This way we are testing linux thread support, which is more useful
than functioning as a test case for PR gcc/5725.

I tested this patch on:

[target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=2.95.3 glibc=vendor goption=-gdwarf-2]
[target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=2.95.3 glibc=vendor goption=-gstabs+]
[target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=3.0.3 glibc=vendor goption=-gdwarf-2]
[target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=3.0.3 glibc=vendor goption=-gstabs+]
[target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=3.0.4-20020215 glibc=vendor goption=-gdwarf-2]
[target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=3.0.4-20020215 glibc=vendor goption=-gstabs+]
[target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=3.0.4 glibc=vendor goption=-gdwarf-2]
[target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=3.0.4 glibc=vendor goption=-gstabs+]
[target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=gcc-3_0-branch%20020222 glibc=vendor goption=-gdwarf-2]
[target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=gcc-3_0-branch%20020222 glibc=vendor goption=-gstabs+]
[target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=HEAD%20020222 glibc=vendor goption=-gdwarf-2]
[target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=HEAD%20020222 glibc=vendor goption=-gstabs+]

References:

Jason's message about the new warning:
http://gcc.gnu.org/ml/gcc-patches/2002-02/msg00034.html

My reply in the thread:
http://gcc.gnu.org/ml/gcc-patches/2002-02/msg00704.html

My gcc PR:
http://gcc.gnu.org/cgi-bin/gnatsweb.pl?database=gcc&cmd=view&pr=5725

Okay to apply?

Michael C

===

2002-02-18 Michael Chastain <mec@shout.net>

* gdb.threads/linux-dp.c (philosopher): Add a return statement
to placate gcc.

Index: gdb/testsuite/gdb.threads/linux-dp.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/linux-dp.c,v
retrieving revision 1.1.1.1
diff -c -3 -p -r1.1.1.1 linux-dp.c
*** linux-dp.c 1999/10/19 02:46:48 1.1.1.1
--- linux-dp.c 2002/02/18 21:37:54
*************** philosopher (void *data)
*** 153,158 ****
--- 153,160 ----
pthread_mutex_unlock (&fork_mutex[(n + 1) % num_philosophers]);
random_delay ();
}
+
+ return (void *) 0;
}

int