From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8299 invoked by alias); 23 Feb 2002 23:28:52 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8223 invoked from network); 23 Feb 2002 23:28:50 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 23 Feb 2002 23:28:50 -0000 Received: from telocity.telocity.com (taarna.cygnus.com [205.180.230.102]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with SMTP id PAA05227; Sat, 23 Feb 2002 15:28:36 -0800 (PST) Message-ID: <3C78245E.4850@redhat.com> Date: Sat, 23 Feb 2002 15:28:00 -0000 From: Michael Snyder X-Mailer: Mozilla 3.04 (Win95; I) MIME-Version: 1.0 To: Michael Elizabeth Chastain CC: gdb-patches@sources.redhat.com Subject: Re: [RFA #2] gdb.threads/linux-dp.c: accommodate gcc 3.1 References: <200202232245.g1NMjNE28966@duracef.shout.net> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-02/txt/msg00652.txt.bz2 Michael Elizabeth Chastain wrote: > > This is RFA #2 for this patch. > > gcc HEAD has a new warning: > > warning: no return statement in function returning non-void > > Unfortunately this breaks code in gdb.threads/linux-dp.c: > > void * > philosopher (void *data) > { > ... > for (;;) > { > ... > } > } > > I consider this to be a bug in gcc HEAD, and I've filed PR gcc/5725. > > Meanwhile, I would like to change linux-dp.c so that it compiles. > This way we are testing linux thread support, which is more useful > than functioning as a test case for PR gcc/5725. > > I tested this patch on: > > [target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=2.95.3 glibc=vendor goption=-gdwarf-2] > [target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=2.95.3 glibc=vendor goption=-gstabs+] > [target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=3.0.3 glibc=vendor goption=-gdwarf-2] > [target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=3.0.3 glibc=vendor goption=-gstabs+] > [target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=3.0.4-20020215 glibc=vendor goption=-gdwarf-2] > [target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=3.0.4-20020215 glibc=vendor goption=-gstabs+] > [target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=3.0.4 glibc=vendor goption=-gdwarf-2] > [target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=3.0.4 glibc=vendor goption=-gstabs+] > [target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=gcc-3_0-branch%20020222 glibc=vendor goption=-gdwarf-2] > [target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=gcc-3_0-branch%20020222 glibc=vendor goption=-gstabs+] > [target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=HEAD%20020222 glibc=vendor goption=-gdwarf-2] > [target=native host=i686-pc-linux%rh-7.2 gdb=HEAD gcc=HEAD%20020222 glibc=vendor goption=-gstabs+] > > References: > > Jason's message about the new warning: > http://gcc.gnu.org/ml/gcc-patches/2002-02/msg00034.html > > My reply in the thread: > http://gcc.gnu.org/ml/gcc-patches/2002-02/msg00704.html > > My gcc PR: > http://gcc.gnu.org/cgi-bin/gnatsweb.pl?database=gcc&cmd=view&pr=5725 > > Okay to apply? > > Michael C Looks good to me... > > === > > 2002-02-18 Michael Chastain > > * gdb.threads/linux-dp.c (philosopher): Add a return statement > to placate gcc. > > Index: gdb/testsuite/gdb.threads/linux-dp.c > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/linux-dp.c,v > retrieving revision 1.1.1.1 > diff -c -3 -p -r1.1.1.1 linux-dp.c > *** linux-dp.c 1999/10/19 02:46:48 1.1.1.1 > --- linux-dp.c 2002/02/18 21:37:54 > *************** philosopher (void *data) > *** 153,158 **** > --- 153,160 ---- > pthread_mutex_unlock (&fork_mutex[(n + 1) % num_philosophers]); > random_delay (); > } > + > + return (void *) 0; > } > > int