Re: [rfa:testsuite} Overhaul sizeof.exp

Michael Elizabeth Chastain
2002-02-19T23:46:12Z

A nit: there is an extraneous change to call-ar-st.exp.

Bigger nit: the ChangeLog says that it's about sizeof.exp, but the patch
includes changes to sizeof.c.

The real feedback: I threw it in the native i686-pc-linux-gnu test bed
for a quick before-and-after, Nothing broke, but one of the
the new tests FAILs in all configurations.

FAIL: gdb.base/sizeof.exp: print/d padding_long_double.v = 4
target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=2.95.3, goption=-gdwarf-2
target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=2.95.3, goption=-gstabs+
target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=3.0.3, goption=-gdwarf-2
target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=3.0.3, goption=-gstabs+
target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=3.0.4-20020215, goption=-gdwarf-2
target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=3.0.4-20020215, goption=-gstabs+
target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=gcc-3_0-branch%2002-02-16, goption=-dwarf-2
target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=gcc-3_0-branch%2002-02-16, goption=-gstabs+
target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=HEAD%2002-02-16, goption=-dwarf-2
target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=HEAD%2002-02-16, goption=-gstabs+

Here is a log excerpt:

# target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=3.0.3, goption=-gstabs+
print padding_long_double.p1^M
$35 = "The quick brown "^M
(gdb) PASS: gdb.base/sizeof.exp: print padding_long_double.p1
print/d padding_long_double.v = 4^M
$36 = 2523330444660750855469793280^M
(gdb) FAIL: gdb.base/sizeof.exp: print/d padding_long_double.v = 4
print padding_long_double.p2^M
$37 = "The quick brown "^M
(gdb) PASS: gdb.base/sizeof.exp: print padding_long_double.p2

All 10 gdb.log files have the same constant value for $36.

Michael C