> A nit: there is an extraneous change to call-ar-st.exp.

How did that sneak its way in :-(  Ulgh, I updated the copyright on the 
wrong file (I'll try to blame emacs ...).

> Bigger nit: the ChangeLog says that it's about sizeof.exp, but the patch
> includes changes to sizeof.c.

Will fix.

> Here is a log excerpt:
> 
>   # target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=3.0.3, goption=-gstabs+
>   print padding_long_double.p1^M
>   $35 = "The quick brown "^M
>   (gdb) PASS: gdb.base/sizeof.exp: print padding_long_double.p1
>   print/d padding_long_double.v = 4^M
>   $36 = 2523330444660750855469793280^M
>   (gdb) FAIL: gdb.base/sizeof.exp: print/d padding_long_double.v = 4
>   print padding_long_double.p2^M
>   $37 = "The quick brown "^M
>   (gdb) PASS: gdb.base/sizeof.exp: print padding_long_double.p2
> 
> All 10 gdb.log files have the same constant value for $36.

(evil laughter :-)  The print/d statement was wrong - it should not 
include the assignment and instead should look like:

(gdb) PASS: gdb.base/sizeof.exp: print padding_double.p2
set padding_long_double.v = 4
(gdb) PASS: gdb.base/sizeof.exp: set padding_long_double.v = 4
print padding_long_double.p1
$35 = "The quick brown "
(gdb) PASS: gdb.base/sizeof.exp: print padding_long_double.p1
print/d padding_long_double.v
$36 = 4
(gdb) PASS: gdb.base/sizeof.exp: print/d padding_long_double.v
print padding_long_double.p2
$37 = "The quick brown "
(gdb) PASS: gdb.base/sizeof.exp: print padding_long_double.p2

The attached includes that fixes.

Unfortunatly it doesn't address the x86 problem.  Looking at 
printcmd.c:print_scalar_formatted() the function behaves differently 
when sizeof (host LONGEST) < sizeof (target type) (i.e. x86) :-(  I 
think this a very long standing bug.

The problem I guess is what to do short term with this part of the test.

sigh,
Andrew

(updated change attached)