Re: [RFA] gdbserver 3/3 - new code

Daniel Jacobowitz
2002-02-14T06:21:21Z

On Wed, Feb 13, 2002 at 11:29:47PM -0500, Andrew Cagney wrote:
> Only a style nit - wrap the headers in #ifndef #define #endif. Oh and
> you're going to have some fun with fnchange.list :-)

Nit noted, will fix before I commit it. I'm actually not going to have
a problem with fnchange.lst - that's why the files are named
linux-arm-low.c instead of low-linux-arm.c like they used to be. It
may come up, though :)

I even went through and fixed all the copyright dates I missed the
first time, too.

> The other one is with regformats/* How sure are you that the regformats
> so described aren't GNU/Linux (yes check that as well :-) specific?

I tried to verify that all of them were architecture independent. We
have mechanism in place to cope if I'm wrong; and I can update them to
have comments describing where they are and are not appropriate if we
find somewhere they are not.

I'll scan for GNU/Linux, thanks for the reminder. One in each
architecture file needed to be fixed.

> If you can add a news entry, I can get the web pages updated.

I'll do that in the next day or two. Thanks. Committed otherwise;
tree builds again.

--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer