From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31932 invoked by alias); 13 Feb 2002 18:04:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31805 invoked from network); 13 Feb 2002 18:04:06 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 13 Feb 2002 18:04:06 -0000 Received: from telocity.telocity.com (taarna.cygnus.com [205.180.230.102]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with SMTP id KAA29269; Wed, 13 Feb 2002 10:03:49 -0800 (PST) Message-ID: <3C6AA952.5179@redhat.com> Date: Wed, 13 Feb 2002 10:04:00 -0000 From: Michael Snyder X-Mailer: Mozilla 3.04 (Win95; I) MIME-Version: 1.0 To: Andrew Cagney CC: Michael Elizabeth Chastain , gdb-patches@sources.redhat.com Subject: Re: [RFA] nuke CONST_PTR References: <200202131444.g1DEi0e02865@duracef.shout.net> <3C6A8FCD.2D1D@redhat.com> <3C6AA2BA.8090001@cygnus.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-02/txt/msg00364.txt.bz2 Andrew Cagney wrote: > > > In gdb 4.18 and gdb 5.0, CONST_PTR was conditionally defined as nothing > >> if MSC_VER was defined, and "const" otherwise. In gdb 5.1 and gdb 5.1.1, > >> CONST_PTR is always defined to "const". So CONST_PTR has been > >> unconditionally defined for only a few months. > >> > >> However, in gdb 4.18, gdb 5.0, gdb 5.1, and gdb 5.1, c-lang.c has also > >> contained this line: > >> > >> struct type **const (cplus_builtin_types[]) = > >> > >> So this form has been in gdb source code for four releases already > >> without drawing complaint. > >> > >> Testing: I built this on native i686-pc-linux-gnu and ran the test suite. > >> > >> Okay to apply? > > > > > > Your reasoning seems good, but your testing doesn't. > > Seems to me you need to test this when building with Microsoft C. > > > > OTOH, do we ever build with Microsoft C any more? > > Is there any reason to support it? Cygwin and Djgcc > > are both self-hosting, aren't they? > > Not since '98! The line: > > >> struct type **const (cplus_builtin_types[]) = > > was added in '98 so ever since then GDB hasn't been able to build with > the MSC compiler CONST_PTR was working around. As Michael pointed out, > we've had 4 releases since then. OK, then this change seems safe. Maybe we can also start yanking out other #if MSC code...