From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24725 invoked by alias); 13 Feb 2002 17:30:45 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24471 invoked from network); 13 Feb 2002 17:30:36 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 13 Feb 2002 17:30:36 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 163BA3C8E; Wed, 13 Feb 2002 12:30:34 -0500 (EST) Message-ID: <3C6AA2BA.8090001@cygnus.com> Date: Wed, 13 Feb 2002 09:30:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.8) Gecko/20020210 X-Accept-Language: en-us MIME-Version: 1.0 To: Michael Snyder Cc: Michael Elizabeth Chastain , gdb-patches@sources.redhat.com Subject: Re: [RFA] nuke CONST_PTR References: <200202131444.g1DEi0e02865@duracef.shout.net> <3C6A8FCD.2D1D@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-02/txt/msg00362.txt.bz2 > In gdb 4.18 and gdb 5.0, CONST_PTR was conditionally defined as nothing >> if MSC_VER was defined, and "const" otherwise. In gdb 5.1 and gdb 5.1.1, >> CONST_PTR is always defined to "const". So CONST_PTR has been >> unconditionally defined for only a few months. >> >> However, in gdb 4.18, gdb 5.0, gdb 5.1, and gdb 5.1, c-lang.c has also >> contained this line: >> >> struct type **const (cplus_builtin_types[]) = >> >> So this form has been in gdb source code for four releases already >> without drawing complaint. >> >> Testing: I built this on native i686-pc-linux-gnu and ran the test suite. >> >> Okay to apply? > > > Your reasoning seems good, but your testing doesn't. > Seems to me you need to test this when building with Microsoft C. > > OTOH, do we ever build with Microsoft C any more? > Is there any reason to support it? Cygwin and Djgcc > are both self-hosting, aren't they? Not since '98! The line: >> struct type **const (cplus_builtin_types[]) = was added in '98 so ever since then GDB hasn't been able to build with the MSC compiler CONST_PTR was working around. As Michael pointed out, we've had 4 releases since then. enjoy, Andrew