From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-12689-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 1254 invoked by alias); 10 Feb 2002 16:39:37 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 1204 invoked from network); 10 Feb 2002 16:39:34 -0000
Received: from unknown (HELO localhost.redhat.com) (24.114.26.18)
  by sources.redhat.com with SMTP; 10 Feb 2002 16:39:34 -0000
Received: from cygnus.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id A6F863C83; Sun, 10 Feb 2002 11:39:25 -0500 (EST)
Message-ID: <3C66A23D.1080700@cygnus.com>
Date: Sun, 10 Feb 2002 08:39:00 -0000
From: Andrew Cagney <ac131313@cygnus.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.7) Gecko/20020103
X-Accept-Language: en-us
MIME-Version: 1.0
To: thorpej@wasabisystems.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch] Use MAXPATHLEN, fix sunos build problem
References: <3C4A12B7.3040502@cygnus.com> <20020119173843.N8364@dr-evil.shagadelic.org> <3C4A31EB.5080504@cygnus.com> <20020119192943.O8364@dr-evil.shagadelic.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-02/txt/msg00304.txt.bz2

> On Sat, Jan 19, 2002 at 07:43:35PM -0500, Andrew Cagney wrote:
> 
>  > 2002-01-19  Andrew Cagney  <ac131313@redhat.com>
>> > * utils.c: Include <sys/param.h> for MAXPATHLEN.
>  > (gdb_realpath): Use MAXPATHLEN when PATH_MAX is not defined.
> 
> Seems like you really want PATH_MAX to be an autoconf test, and if
> not, then test for MAXPATHLEN in <sys/param.h> and define PATH_MAX
> in terms of MAXPATHLEN.
> 
> Basically, <machine/param.h> is by no means a standardized header, and
> pulling it in causes all sorts of namespace pollution, so you wanna
> use it only if you have to.


This really begs a question.  Should we put a bomb under utils.c 
breaking it up into smaller chunks (gdb/utils/*.c) so that people can be 
more confident about this.

At present utils.c contains so much that someone trying to change it is 
never really sure what the consequences of an include file tweek are.

Andrew