Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@redhat.com>
To: Klee Dienes <kdienes@apple.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] Allow '!' in program paths
Date: Wed, 06 Feb 2002 16:56:00 -0000	[thread overview]
Message-ID: <3C61CF14.B33024AC@redhat.com> (raw)
In-Reply-To: <F7C3F3F9-1B5B-11D6-8F8D-0030653FA4C6@apple.com>

Klee Dienes wrote:
> 
> 2002-02-06  Klee Dienes  <klee@apple.com>
> 
>          * fork-inferior.c (fork_inferior): Add '!' to the list of
>          characters that need to be quoted when building a string for the
>          shell.  Quote '!' specifically with a backslash, since CSH chokes
>          when trying to evaluate "str!str".

Seems sane to me.  Wanna check it in?

> 
> Index: fork-child.c
> ===================================================================
> RCS file: /cvs/Darwin/Commands/GNU/cygnus/src/gdb/fork-child.c,v
> retrieving revision 1.9
> diff -u -r1.9 fork-child.c
> --- fork-child.c        2001/11/29 00:18:44     1.9
> +++ fork-child.c        2002/02/06 22:53:11
> @@ -204,6 +204,7 @@
>            switch (*p)
>              {
>              case '\'':
> +           case '!':
>              case '"':
>              case '(':
>              case ')':
> @@ -235,6 +236,8 @@
>              {
>                if (*p == '\'')
>                  strcat (shell_command, "'\\''");
> +             else if (*p == '!')
> +               strcat (shell_command, "\\!");
>                else
>                  strncat (shell_command, p, 1);
>              }


  reply	other threads:[~2002-02-07  0:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-06 15:48 Klee Dienes
2002-02-06 16:56 ` Michael Snyder [this message]
2002-03-09 19:12 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C61CF14.B33024AC@redhat.com \
    --to=msnyder@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kdienes@apple.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox