Confusion over the definition of 'bool' in rdi-share/host.h

Nick Clifton
2002-02-05T18:11:52Z

Hi Guys,

The ARM port of GDB is currently failing to build for me because of
this problem:

In file included from /home/nickc/work/sources/egcs/gdb/rdi-share/ardi.h:17,
from /home/nickc/work/sources/egcs/gdb/remote-rdi.c:46:
/home/nickc/work/sources/egcs/gdb/rdi-share/host.h:123: conflicting types for `_Bool'
/usr/lib/gcc-lib/i386-redhat-linux/2.96/include/stdbool.h:41: previous declaration of `_Bool'

It seems that host.h has code that looks like this (trimmed a little):

# define _bool int

#ifdef _bool
typedef _bool bool;
#endif

And stdbool.h has:

typedef enum
{
false = 0,
true = 1
} _Bool;

#define bool _Bool

So the typedef in host.h becomes, effectively "typedef int enum _Bool".

I am not sure if we are allowed to modify rdi-share/host.h, it
appears to be copyright to ARM, but if we are, then may I submit the
following patch to undefine bool before it is used ?

Cheers
Nick

2002-02-05 Nick Clifton <nickc@cambridge.redhat.com>

* rdi-share/host.h: Before creating a typedef from _bool, make
sure that bool is not defined.

Index: gdb/rdi-share/host.h
===================================================================
RCS file: /cvs/src/src/gdb/rdi-share/host.h,v
retrieving revision 1.4
diff -c -3 -p -w -r1.4 host.h
*** host.h 2001/06/29 01:19:23 1.4
--- host.h 2002/02/05 17:48:54
*************** typedef unsigned char unsigned8;
*** 120,125 ****
--- 120,128 ----
# if defined(_MFC_VER) || defined(__CC_NORCROFT) /* When using MS Visual C/C++ v4.2 */
# define bool _bool /* avoids "'bool' is reserved word" warning */
# else
+ # ifdef bool
+ # undef bool
+ # endif
typedef _bool bool;
# endif
# define true _true