Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Jim Blandy <jimb@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: Do solib address arithmetic with appropriate truncation
Date: Sun, 03 Feb 2002 10:24:00 -0000	[thread overview]
Message-ID: <3C5D755D.4030201@cygnus.com> (raw)
In-Reply-To: <20020203013131.C26295E9DE@zwingli.cygnus.com>

> + /* Clear any bits of ADDR that wouldn't fit in a target-format
> +    data pointer.  "Data pointer" here refers to whatever sort of
> +    address the dynamic linker uses to manage its sections.  At the
> +    moment, we don't support shared libraries on any processors where
> +    code and data pointers are different sizes.  */
> + static CORE_ADDR
> + svr4_truncate_ptr (CORE_ADDR addr)
> + {
> +   if (TARGET_PTR_BIT == sizeof (CORE_ADDR) * 8)
> +     /* We don't need to truncate anything, and the bit twiddling below
> +        will fail due to overflow problems.  */
> +     return addr;
> +   else
> +     return addr & (((CORE_ADDR) 1 << TARGET_PTR_BIT) - 1);
> + }


There must be something around that this code can use.  On something 
like a mips, this would be wrong - remember the sign extension problem.

Andrew


  reply	other threads:[~2002-02-03 18:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-02 17:29 Jim Blandy
2002-02-03 10:24 ` Andrew Cagney [this message]
2002-02-04  8:15   ` Kevin Buettner
2002-02-04  9:01     ` Andrew Cagney
2002-02-05 16:07       ` Jim Blandy
2002-02-05 16:39         ` Andrew Cagney
2002-02-06 11:27           ` Jim Blandy
2002-02-06 11:41             ` Andrew Cagney
2002-02-06 14:12             ` Daniel Jacobowitz
2002-02-03 23:09 ` Kevin Buettner
2002-02-05 15:30   ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C5D755D.4030201@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox