From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12261 invoked by alias); 29 Jan 2002 03:19:23 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12228 invoked from network); 29 Jan 2002 03:19:20 -0000 Received: from unknown (HELO localhost.cygnus.com) (24.114.42.213) by sources.redhat.com with SMTP; 29 Jan 2002 03:19:20 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.cygnus.com (Postfix) with ESMTP id 91D383D61; Mon, 28 Jan 2002 22:19:11 -0500 (EST) Message-ID: <3C5614AF.4050809@cygnus.com> Date: Mon, 28 Jan 2002 19:19:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.7) Gecko/20020103 X-Accept-Language: en-us MIME-Version: 1.0 To: Michael Snyder Cc: gdb-patches@sources.redhat.com, cagney@redhat.com Subject: Re: [RFA] legacy_[read/write]_register_gen References: <200201290102.g0T12Uk24471@reddwarf.cygnus.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-01/txt/msg00748.txt.bz2 > These two functions need to be able to read/write > a pseudo-register as well as a real register. > > 2002-01-28 Michael Snyder > > * regcache.c (legacy_read_register_gen): Need to be able to > read pseudo-register as well as real register. > (legacy_write_register_gen): Ditto. Michael, When is this occuring? Dig dig, I've a similar patch sitting in my sand-pit so, hmm, I've also seen it but don't remember why :-( Andrew > Index: regcache.c > =================================================================== > RCS file: /cvs/src/src/gdb/regcache.c,v > retrieving revision 1.30 > diff -c -3 -p -r1.30 regcache.c > *** regcache.c 2002/01/15 02:06:46 1.30 > --- regcache.c 2002/01/29 01:02:29 > *************** legacy_read_register_gen (int regnum, ch > *** 310,316 **** > void > regcache_read (int rawnum, char *buf) > { > ! gdb_assert (rawnum >= 0 && rawnum < NUM_REGS); > /* For moment, just use underlying legacy code. Ulgh!!! */ > legacy_read_register_gen (rawnum, buf); > } > --- 310,316 ---- > void > regcache_read (int rawnum, char *buf) > { > ! gdb_assert (rawnum >= 0 && rawnum < (NUM_REGS + NUM_PSEUDO_REGS)); > /* For moment, just use underlying legacy code. Ulgh!!! */ > legacy_read_register_gen (rawnum, buf); > } > *************** legacy_write_register_gen (int regnum, c > *** 369,375 **** > void > regcache_write (int rawnum, char *buf) > { > ! gdb_assert (rawnum >= 0 && rawnum < NUM_REGS); > /* For moment, just use underlying legacy code. Ulgh!!! */ > legacy_write_register_gen (rawnum, buf); > } > --- 369,375 ---- > void > regcache_write (int rawnum, char *buf) > { > ! gdb_assert (rawnum >= 0 && rawnum < (NUM_REGS + NUM_PSEUDO_REGS)); > /* For moment, just use underlying legacy code. Ulgh!!! */ > legacy_write_register_gen (rawnum, buf); > } > > >