From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10080 invoked by alias); 28 Mar 2019 11:02:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10008 invoked by uid 89); 28 Mar 2019 11:02:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.7 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=holiday, interest X-HELO: EUR04-VI1-obe.outbound.protection.outlook.com Received: from mail-eopbgr80083.outbound.protection.outlook.com (HELO EUR04-VI1-obe.outbound.protection.outlook.com) (40.107.8.83) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Mar 2019 11:02:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5mwp2m3h12cy6GydOgKhjJA5Oj0ymLvEoRt5ye2pR/s=; b=iDudwLs7fuSkAdMlxUcn12MMpXJep40Uk30J2xMN7r8WJuSs8K6bGokcXjEtsBC8f64pbWWakVjVu+Z11wNMfQfzhQyAqopmPHP9BsQE5rz8iA0Ix0TTRJEFNcCnH9+4i5k3FzMZzhFaqnUZJQByif9yjRWJGRB2RIeH/SL6dOc= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2471.eurprd08.prod.outlook.com (10.172.250.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.17; Thu, 28 Mar 2019 11:02:40 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::d122:4a29:4ae4:790c]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::d122:4a29:4ae4:790c%10]) with mapi id 15.20.1750.014; Thu, 28 Mar 2019 11:02:40 +0000 From: Alan Hayward To: Kevin Buettner CC: GDB Patches , nd Subject: Re: [RFC/PATCH] Testsuite: set sysroot when using gdbserver Date: Thu, 28 Mar 2019 11:02:00 -0000 Message-ID: <3C508419-659A-46F9-915E-0F96AF6FBC91@arm.com> References: <20190327164025.48105-1-alan.hayward@arm.com> <20190327134915.5e9b19ba@f29-4.lan> <20190327221438.1fade1ef@f29-4.lan> In-Reply-To: <20190327221438.1fade1ef@f29-4.lan> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 Content-Type: text/plain; charset="utf-8" Content-ID: <1A7D15EA3430824099FD4E18B47678BA@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00702.txt.bz2 DQoNCj4gT24gMjggTWFyIDIwMTksIGF0IDA1OjE0LCBLZXZpbiBCdWV0dG5l ciA8a2V2aW5iQHJlZGhhdC5jb20+IHdyb3RlOg0KPiANCj4gSGkgQWxhbiwN Cj4gDQo+IEkgd2FudCB0byBhcG9sb2dpemUgaW4gY2FzZSBteSBsYXR0ZXIg Y29tbWVudCBjYW1lIGFjcm9zcyBhcyBoYXJzaC4gIEkNCj4gdGhpbmsgSSBj b3VsZCBoYXZlIHBocmFzZWQgaXQgbW9yZSBkaXBsb21hdGljYWxseS4NCg0K T2gsIG5vLCB0aGF04oCZcyBmaW5lIDopDQoNCj4gDQo+IEknbGwgbm90ZSB0 aGF0IEkgYWxzbyBoYXZlIGFuIGludGVyZXN0IGluIHNldHRpbmcgdXAgc3lz cm9vdCBmb3IgdGhlDQo+IE9wZW5NUCB0ZXN0cyB0aGF0IEkndmUgYmVlbiB3 b3JraW5nIG9uLiAgU28gSSBhbSBnZW51aW5lbHkgaW50ZXJlc3RlZA0KPiBp biB3aGV0aGVyIG9yIGhvdyBzeXNyb290IGNhbiBiZSBzZXQgZnJvbSBhIGJv YXJkIGZpbGUuDQo+IA0KPiBBbHNvLCBtYWtpbmcgdGhlIHRlc3RzIHJ1biBm YXN0ZXIgaXMgZGVmaW5pdGVseSBhIGdvb2QgdGhpbmcsIHNvDQo+IHRoYW5r cyBmb3IgbG9va2luZyBpbnRvIHRoaXMuDQoNCg0KSSBkb27igJl0IGtub3cg bXVjaCBhYm91dCBob3cgdGhlIGJvYXJkIGZpbGVzIHdvcmssIGJ1dCwgbG9v a3MgbGlrZSBJIGNhbg0KanVzdCBhZGQgYSBmbGFnIHZpYSDigJxzZXRfYm9h cmRfaW5mb+KAnSBpbiB0aGUgcmVsZXZhbnQgYm9hcmQgZmlsZXMuDQoNCkkg Y2FuIHRoZW4gY2hlY2sgZm9yIGl0IGF0IHRoZSBlbmQgb2YgZ2Ric2VydmVy X3N0YXJ0LiBPciBpbnN0ZWFkIGNoZWNrDQphdCB0aGUgc2FtZSBwbGFjZSDi gJx0YXJnZXQgcmVtb3Rl4oCdIGlzIHJ1biAoYWx0aG91Z2ggSSBjb3VsZG7i gJl0IGZpbmQgd2hlcmUNCnRoYXQgd2FzIHllc3RlcmRheSEpLg0KDQpUaGlz IGxvb2tzIGxpa2UgYSBtdWNoIGJldHRlciB3YXkgb2YgZG9pbmcgaXQuDQoN CknigJltIGdvaW5nIHRvIHdlIG9uIGhvbGlkYXkgZm9yIHRoZSBuZXh0IHdl ZWssIHNvIEkgZG91YnQgSeKAmWxsIGJlIGFibGUgdG8NCmdldCBhIG5ldyBw YXRjaCB0b2dldGhlciBiZWZvcmUgdGhlbi4gIEkgd2lsbCBsb29rIGF0IGl0 IGFzIHNvb24gYXMgSSBnZXQNCmJhY2ssIGFzIEnigJlkIGxpa2UgdG8gZ2V0 IHJpZCBvZiB0aGUgYnVpbGRib3QgdGltZW91dHMuDQoNCkFsYW4uDQoNCj4g DQo+IEtldmluDQo+IA0KPiBPbiBXZWQsIDI3IE1hciAyMDE5IDEzOjQ5OjE1 IC0wNzAwDQo+IEtldmluIEJ1ZXR0bmVyIDxrZXZpbmJAcmVkaGF0LmNvbT4g d3JvdGU6DQo+IA0KPj4gT24gV2VkLCAyNyBNYXIgMjAxOSAxNjo0MDozMCAr MDAwMA0KPj4gQWxhbiBIYXl3YXJkIDxBbGFuLkhheXdhcmRAYXJtLmNvbT4g d3JvdGU6DQo+PiANCj4+PiBIb3dldmVyLCBJJ20gbm90IHN1cmUgaWYgcHV0 dGluZyB0aGUgc3lzcm9vdCBpbnRvIGdkYnNlcnZlcl9zdGFydCB3aWxsIGJy ZWFrDQo+Pj4gb3RoZXIgcmVtb3RlIHNldHVwcy4gIEluIGFkZGl0aW9uLCBJ IGRvbid0IHRoaW5rIGdkYl90ZXN0IGlzIHRoZSBjb3JyZWN0DQo+Pj4gZnVu Y3Rpb24gdG8gY2FsbCB3aXRoaW4gdGhlIGxpYnJhcnkgLSBmb3IgdGhlIG1p IHRlc3RzIHRoaXMgY2F1c2VzIGEgdGltZW91dA0KPj4+IGFzIGl0IGV4cGVj dCB0byB1c2UgbWlfZ2RiX3Rlc3QuICANCj4+IA0KPj4gQ2FuIHN5c3Jvb3Qg YmUgc2V0IGluIHRoZSBib2FyZCBmaWxlKHMpPw0KPj4gDQo+PiBJZiBzbywg SSB0aGluayB0aGF0IHdvdWxkIGJlIHByZWZlcmFibGUgdG8geW91ciBwcm9w b3NlZCBwYXRjaC4NCj4+IA0KPj4gS2V2aW4NCg0K >From gdb-patches-return-155015-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Mar 28 11:32:53 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 99486 invoked by alias); 28 Mar 2019 11:32:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 99445 invoked by uid 89); 28 Mar 2019 11:32:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=downloading X-HELO: mail-wm1-f67.google.com Received: from mail-wm1-f67.google.com (HELO mail-wm1-f67.google.com) (209.85.128.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Mar 2019 11:32:51 +0000 Received: by mail-wm1-f67.google.com with SMTP id n25so825049wmk.4 for ; Thu, 28 Mar 2019 04:32:50 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4c97:6d52:2cea:997b? ([2001:8a0:f913:f700:4c97:6d52:2cea:997b]) by smtp.gmail.com with ESMTPSA id n189sm3971568wmb.28.2019.03.28.04.32.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Mar 2019 04:32:47 -0700 (PDT) Subject: Re: [RFC/PATCH] Testsuite: set sysroot when using gdbserver To: Alan Hayward , Kevin Buettner References: <20190327164025.48105-1-alan.hayward@arm.com> <20190327134915.5e9b19ba@f29-4.lan> <20190327221438.1fade1ef@f29-4.lan> <3C508419-659A-46F9-915E-0F96AF6FBC91@arm.com> Cc: GDB Patches , nd From: Pedro Alves Message-ID: Date: Thu, 28 Mar 2019 11:32:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <3C508419-659A-46F9-915E-0F96AF6FBC91@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2019-03/txt/msg00703.txt.bz2 Content-length: 1892 On 03/28/2019 11:02 AM, Alan Hayward wrote: > > >> On 28 Mar 2019, at 05:14, Kevin Buettner wrote: >> >> Hi Alan, >> >> I want to apologize in case my latter comment came across as harsh. I >> think I could have phrased it more diplomatically. > > Oh, no, that’s fine :) > >> >> I'll note that I also have an interest in setting up sysroot for the >> OpenMP tests that I've been working on. So I am genuinely interested >> in whether or how sysroot can be set from a board file. >> >> Also, making the tests run faster is definitely a good thing, so >> thanks for looking into this. > IMO we could also look at this from the perspective that the slowness is something that we should tackle, improve in gdb somehow. For example, we could improve caching a lot. We have a readahead cache for vFile:pread, but we could also have a persistent cache layer, so that we wouldn't be downloading the same shared library files over and over again. > > I don’t know much about how the board files work, but, looks like I can > just add a flag via “set_board_info” in the relevant board files. > > I can then check for it at the end of gdbserver_start. Or instead check > at the same place “target remote” is run (although I couldn’t find where > that was yesterday!). Probably just adding set GDBFLAGS "${GDBFLAGS} -ex \"set sysroot /\"" to testsuite/boards/local-board.exp is all you'd need. I think it'd be good to have a testcase in gdb.server/ that explicitly tests debugging a bit with "set sysroot target:" enabled, so that we don't lose coverage of that. > This looks like a much better way of doing it. > > I’m going to we on holiday for the next week, so I doubt I’ll be able to > get a new patch together before then. I will look at it as soon as I get > back, as I’d like to get rid of the buildbot timeouts. Thanks, Pedro Alves