From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21187 invoked by alias); 21 Jan 2002 16:51:30 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21081 invoked from network); 21 Jan 2002 16:51:25 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 21 Jan 2002 16:51:25 -0000 Received: from redhat.com (rtl.sfbay.redhat.com [205.180.230.21]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id IAA09489; Mon, 21 Jan 2002 08:51:14 -0800 (PST) Message-ID: <3C4C46E8.F48A93D7@redhat.com> Date: Mon, 21 Jan 2002 08:51:00 -0000 From: Fernando Nasser Organization: Red Hat Canada X-Mailer: Mozilla 4.78 [en] (X11; U; Linux 2.4.9-13 i686) X-Accept-Language: en MIME-Version: 1.0 To: Eli Zaretskii CC: Andrew Cagney , gdb-patches@sources.redhat.com Subject: Re: [rfa/cli] s/NO_FUNCTION/NULL/ References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-01/txt/msg00651.txt.bz2 Eli Zaretskii wrote: > > On Sun, 20 Jan 2002, Andrew Cagney wrote: > > > Do you have any problems with the below? > > > > Andrew > > > > > Hello, > > > > > > The attached replaces the NO_FUNCTION macro with NULL. If you > > > examine the code, function.cfunc() is only sometimes assigned the > > > value NO_FUNCTION and no code actually tests for a value of > > > NO_FUNCTION. Consequently, I can't see any point in having this > > > macro. > > IMHO, someone should test this change with the latest versions of GCC, > including their development line: they could have their own ideas when > you are allowed to pass NULL, especially with all the warning options > we use. Besides, the NO_FUNCTION documents the meaning better than NULL (although most people should guess). Maybe you can add a comment somewhere nearby. Any chance Eli's concerns become true and we get a warning because NULL is not typed properly? Maybe you would need a cast (in which case I would prefer the NO_FUNCTION def. Regards, Fernando -- Fernando Nasser Red Hat Canada Ltd. E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9