From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6357 invoked by alias); 21 Jan 2002 16:35:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6325 invoked from network); 21 Jan 2002 16:35:00 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 21 Jan 2002 16:35:00 -0000 Received: from redhat.com (rtl.sfbay.redhat.com [205.180.230.21]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id IAA07870; Mon, 21 Jan 2002 08:34:56 -0800 (PST) Message-ID: <3C4C4316.5BA498A6@redhat.com> Date: Mon, 21 Jan 2002 08:35:00 -0000 From: Fernando Nasser Organization: Red Hat Canada X-Mailer: Mozilla 4.78 [en] (X11; U; Linux 2.4.9-13 i686) X-Accept-Language: en MIME-Version: 1.0 To: fnf@redhat.com CC: gdb-patches@sources.redhat.com Subject: Re: [RFA] Patch for THUMB skip_prologue code References: <200201182349.g0INnLU01677@fred.ninemoons.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-01/txt/msg00648.txt.bz2 Auch! Please check it in. Thanks for the patch. Regards, Fernando Fred Fish wrote: > > The current THUMB prologue skipping code does not stop until > it reaches either the end of the function, or an address that > is the function start address plus 40. This patch fixes it. > The gdb testsuite results for thumb code after applying this > patch have the following diff: > > 10694c10694 > < FAIL: gdb.base/nodebug.exp: running to middle in runto > --- > > PASS: gdb.base/nodebug.exp: backtrace from middle in nodebug.exp > 15907,15908c15907,15908 > < # of expected passes 7469 > < # of unexpected failures 104 > --- > > # of expected passes 7470 > > # of unexpected failures 103 > > -Fred > > ============================================================ > > 2002-01-18 Fred Fish > > * arm-tdep.c (thumb_skip_prologue): Quit scanning prologue > when we have found all instructions we are looking for. > > Index: arm-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/arm-tdep.c,v > retrieving revision 1.26 > diff -u -p -r1.26 arm-tdep.c > --- arm-tdep.c 2002/01/09 18:07:48 1.26 > +++ arm-tdep.c 2002/01/18 23:26:14 > @@ -376,6 +376,10 @@ thumb_skip_prologue (CORE_ADDR pc, CORE_ > { > findmask |= 2; /* setting of r7 found */ > } > + else if (findmask == (4+2+1)) > + { > + break; /* We have found one of each type of prologue instruction */ > + } > else > continue; /* something in the prolog that we don't care about or some > instruction from outside the prolog scheduled here for optimization */ -- Fernando Nasser Red Hat Canada Ltd. E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9