From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 664 invoked by alias); 21 Jan 2002 16:19:31 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 574 invoked from network); 21 Jan 2002 16:19:24 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 21 Jan 2002 16:19:24 -0000 Received: from redhat.com (rtl.sfbay.redhat.com [205.180.230.21]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id IAA06177; Mon, 21 Jan 2002 08:19:20 -0800 (PST) Message-ID: <3C4C3F6D.8D98F9B2@redhat.com> Date: Mon, 21 Jan 2002 08:19:00 -0000 From: Fernando Nasser Organization: Red Hat Canada X-Mailer: Mozilla 4.78 [en] (X11; U; Linux 2.4.9-13 i686) X-Accept-Language: en MIME-Version: 1.0 To: fnf@redhat.com CC: gdb-patches@sources.redhat.com Subject: Re: [RFA] Only need one "maint info breakpoint" test References: <200201060714.g067E9l07719@fred.ninemoons.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-01/txt/msg00644.txt.bz2 It looks reasonable to me. Please check it in. Thanks for the patch. Fernando Fred Fish wrote: > > We really only need to run the "maint info breakpoints" test once and > optionally accept the "shlib events" variation. Also tweaked the > whitespace for consistency with the other nearby tests. > > 2002-01-05 Fred Fish > > * gdb.base/maint.exp: Simplify the "maint info breakpoints" test to > optionally accept the "shlib events" variation. > > Index: gdb.base/maint.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/maint.exp,v > retrieving revision 1.9 > diff -c -p -r1.9 maint.exp > *** maint.exp 2002/01/05 02:40:47 1.9 > --- maint.exp 2002/01/06 07:12:22 > *************** gdb_expect { > *** 415,446 **** > > send_gdb "maint info breakpoints\n" > gdb_expect { > ! -re "Num\[ \t\]+Type\[ \t\]+Disp\[ \t\]+Enb\[ \t\]+Address\[ \t\]+What\r\n1\[ \t\]+breakpoint\[ \t\]+keep\[ \t\]+y\[ \t\]+$hex in main at.*break.c:75\r\n\[ \t\]+breakpoint already hit 1 time\r\n.*$gdb_prompt $"\ > ! { pass "maint info breakpoints" } > ! -re ".*$gdb_prompt $" { fail "maint info breakpoints" } > ! timeout { fail "(timeout) maint info breakpoints" } > } > - > - # Try it again, and check for shlib event info. Not supported everywhere. > - if {! ([istarget "hppa*-*-hpux*"] > - || [istarget "*-*-linux*"] > - || [istarget "*-*-solaris*"])} then { > - setup_xfail "*-*-*" > - } > - send_gdb "maint info breakpoints\n" > - gdb_expect { > - -re "Num\[ \t\]+Type\[ \t\]+Disp\[ \t\]+Enb\[ \t\]+Address\[ \t\]+What\r\n1\[ \t\]+breakpoint\[ \t\]+keep\[ \t\]+y\[ \t\]+$hex in main at.*break.c:75\r\n\[ \t\]+breakpoint already hit 1 time\r\n.*$gdb_prompt $"\ > - { pass "maint info breakpoints" } > - -re "Num\[ \t\]+Type\[ \t\]+Disp\[ \t\]+Enb\[ \t\]+Address\[ \t\]+What\r\n1\[ \t\]+breakpoint\[ \t\]+keep\[ \t\]+y\[ \t\]+$hex in main at.*break.c:75\r\n\[ \t\]+breakpoint already hit 1 time\r\n-1\[ \t\]+shlib events\[ \t\]+keep\[ \t\]+y\[ \t\]+$hex.*breakpoint already hit.*$gdb_prompt $"\ > - { pass "maint info breakpoints: shlib events" } > - -re ".*$gdb_prompt $" { > - fail "maint info breakpoints: shlib events" > - } > - timeout { > - fail "(timeout) maint info breakpoints: shlib events" > - } > - } > - > > send_gdb "maint print\n" > gdb_expect { > --- 415,427 ---- > > send_gdb "maint info breakpoints\n" > gdb_expect { > ! -re "Num\[ \t\]+Type\[ \t\]+Disp\[ \t\]+Enb\[ \t\]+Address\[ \t\]+What\r\n1\[ \t\]+breakpoint\[ \t\]+keep\[ \t\]+y\[ \t\]+$hex in main at.*break.c:75\r\n\[ \t\]+breakpoint already hit 1 time\r\n.*$gdb_prompt $"\ > ! { pass "maint info breakpoints" } > ! -re "Num\[ \t\]+Type\[ \t\]+Disp\[ \t\]+Enb\[ \t\]+Address\[ \t\]+What\r\n1\[ \t\]+breakpoint\[ \t\]+keep\[ \t\]+y\[ \t\]+$hex in main at.*break.c:75\r\n\[ \t\]+breakpoint already hit 1 time\r\n-1\[ \t\]+shlib events\[ \t\]+keep\[ \t\]+y\[ \t\]+$hex.*breakpoint already hit.*$gdb_prompt $"\ > ! { pass "maint info breakpoints (with shlib events)" } > ! -re ".*$gdb_prompt $" { fail "maint info breakpoints" } > ! timeout { fail "(timeout) maint info breakpoints" } > } > > send_gdb "maint print\n" > gdb_expect { -- Fernando Nasser Red Hat Canada Ltd. E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9