From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32477 invoked by alias); 21 Jan 2002 16:16:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32442 invoked from network); 21 Jan 2002 16:16:13 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 21 Jan 2002 16:16:13 -0000 Received: from redhat.com (rtl.sfbay.redhat.com [205.180.230.21]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id IAA05914; Mon, 21 Jan 2002 08:16:05 -0800 (PST) Message-ID: <3C4C3EAB.E62D6220@redhat.com> Date: Mon, 21 Jan 2002 08:16:00 -0000 From: Fernando Nasser Organization: Red Hat Canada X-Mailer: Mozilla 4.78 [en] (X11; U; Linux 2.4.9-13 i686) X-Accept-Language: en MIME-Version: 1.0 To: Michael Snyder CC: Andrew Cagney , fnf@redhat.com, gdb-patches@sources.redhat.com Subject: Re: [RFA] Accept simulator exit message References: <200201060632.g066WrV00549@fred.ninemoons.com> <3C4B5CA7.8010003@cygnus.com> <3C4BA99B.3576@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-01/txt/msg00643.txt.bz2 Michael Snyder wrote: > > Andrew Cagney wrote: > > > > Hello, > > > > Did anything come of this patch? > > > > Andrew > > Hang on -- why would it say "program exited normally"? > That would be a bug -- since the program "main" actually > returned one. > > I say, conditionalize this change on some Dejagnu variable > that indicates "target cannot return a value from main". > > Michael > Yes, Fred, please look at the aproved patch from Corinna (which will probably be checked in soon). [RFA]: testsuite/gdb.base/a2-bin.exp: Consider `needs_status_wrapper' target_info Thanks, Fernando > > > > > Accept the message we get when running the a2-run.exp test > > > with the simulator. > > > > > > > > > 2002-01-05 Fred Fish > > > > > > * gdb.base/a2-run.exp: When run in the simulator, the exit > > > message is slightly different so accept that variation. > > > > > > Index: gdb.base/a2-run.exp > > > =================================================================== > > > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/a2-run.exp,v > > > retrieving revision 1.3 > > > diff -u -p -r1.3 a2-run.exp > > > --- a2-run.exp 2001/03/06 08:21:50 1.3 > > > +++ a2-run.exp 2002/01/06 06:30:54 > > > @@ -56,6 +56,7 @@ gdb_load ${binfile} > > > > > > # Run with no arguments. > > > # On VxWorks this justs make sure the program was run. > > > +# When run in the simulator, we get a slightly different exit message. > > > gdb_run_cmd > > > > > > if [istarget "*-*-vxworks*"] then { > > > @@ -78,6 +79,9 @@ if [istarget "*-*-vxworks*"] then { > > > } else { > > > gdb_expect { > > > -re ".*usage: factorial .*Program exited with code 01.*$gdb_prompt $" { > > > + pass "run \"$testfile\" with no args" > > > + } > > > + -re ".*usage: factorial .*Program exited normally.*$gdb_prompt $" { > > > pass "run \"$testfile\" with no args" > > > } > > > -re ".*$gdb_prompt $" { > > > > > > -- Fernando Nasser Red Hat Canada Ltd. E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9