From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-12164-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 26394 invoked by alias); 21 Jan 2002 00:08:30 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 26362 invoked from network); 21 Jan 2002 00:08:30 -0000
Received: from unknown (HELO localhost.cygnus.com) (24.114.42.213)
  by sources.redhat.com with SMTP; 21 Jan 2002 00:08:30 -0000
Received: from cygnus.com (localhost [127.0.0.1])
	by localhost.cygnus.com (Postfix) with ESMTP
	id 1B4433F0A; Sun, 20 Jan 2002 19:08:20 -0500 (EST)
Message-ID: <3C4B5BF3.2070203@cygnus.com>
Date: Sun, 20 Jan 2002 16:08:00 -0000
From: Andrew Cagney <ac131313@cygnus.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.7) Gecko/20020103
X-Accept-Language: en-us
MIME-Version: 1.0
To: gdb-patches <gdb-patches@sources.redhat.com>,
	Fernando Nasser <fnasser@redhat.com>
Subject: Re: [RFA]: testsuite/gdb.base/a2-bin.exp: Consider `needs_status_wrapper' target_info
References: <20011205202507.E29719@cygbert.vinschen.de>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-01/txt/msg00609.txt.bz2

Hello,


Did anything come of this patch?

Andrew

> Hi,
> 
> the first test in a2-bin.exp checks if the return code is 1 when
> the application is called w/o parameter.  Unfortunately there are
> (remote) targets which aren't able to return a return code so that
> the return code is always set to 0.  That results in a failing
> first test in a2-bin.exp even though the target is doing the right
> thing.
> 
> To indicate that a target can't return a return code, there's
> a setting `set_board_info needs_status_wrapper 1' which just
> isn't taken into account in a2-bin.exp.
> 
> The following patch changes that.
> 
> Corinna
> 
> 
> 2001-12-05  Corinna Vinschen  <vinschen@redhat.com>
> 
> * gdb.base/a2-bin.exp: Pass first test even if the return
> 	code is 0 if target_info `needs_status_wrapper' exists.
> 
> 
> Index: a2-run.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/a2-run.exp,v
> retrieving revision 1.3
> diff -u -p -r1.3 a2-run.exp
> --- a2-run.exp	2001/03/06 08:21:50	1.3
> +++ a2-run.exp	2001/12/05 19:10:31
> @@ -80,6 +80,13 @@ if [istarget "*-*-vxworks*"] then {
>  	-re ".*usage:  factorial <number>.*Program exited with code 01.*$gdb_prompt $" {
>  	    pass "run \"$testfile\" with no args"
>  	}
> +	-re ".*usage:  factorial <number>.*Program exited normally.*$gdb_prompt $" {
> +	    if [target_info exists needs_status_wrapper] then {
> +		pass "run \"$testfile\" with no args"
> +	    } else {
> +		fail "run \"$testfile\" with no args"
> +	    }
> +	}
>  	-re ".*$gdb_prompt $" {
>  	    fail "run \"$testfile\" with no args"
>  	    verbose "expect_out is $expect_out(buffer)" 2
> 
> 
>