Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc] Eliminate TARGET_BYTE_ORDER_SELECTABLE
Date: Sun, 20 Jan 2002 11:00:00 -0000	[thread overview]
Message-ID: <3C4B13D1.90007@cygnus.com> (raw)
In-Reply-To: <20020120133632.A22738@nevyn.them.org>

> On Sun, Jan 20, 2002 at 01:33:29PM -0500, Andrew Cagney wrote:
> 
>> >
>> >Woah!  That's neat!  I need to remember that :)
>> >
>> >And I suppose I of all people shouldn't be griping about allowing more
>> >endianness choices.  I have a patch here to support big-endian
>> >ARM/Linux.  All I did was change TARGET_BYTE_ORDER_*.
> 
>> 
>> 
>> Delete it :-)  As Michael observed, if the code is written correctly it 
>> works from day one.  (Problem is it has taken ~10 years to figure out 
>> how to correctly write the code :-)
> 
> 
> Well, I need to set TARGET_BYTE_ORDER_DEFAULT.  If you start a cross
> debugger without giving it a binary, and attach to a random remote
> target, then we need to default to the right one.  Other than that
> everything is fine, though!


Nope! I'm about to delete TARGET_BYTE_ORDER_DEFAULT.

There is this really nasty bit of code in arch-utils.c that roots around 
the internals of BFD and uses that to determine the initial architecture 
and byte-order.  Doing this ensures that GDB's behavour is better 
aligned with that of BINUTILS.
See arch-utils.c:initialize_current_architecture().

If GDB initializes its self to the wrong byte-order then there is likely 
a bug in BFD.

Did I mention that we live in dangerous times :-)
Andrew

PS: Actually the code isn't that bad.  What makes it nasty is the need 
to prop up the old non-multi-arch behavour.


  reply	other threads:[~2002-01-20 19:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-18 21:59 Andrew Cagney
2002-01-19  6:47 ` Daniel Jacobowitz
2002-01-19  8:06   ` Michael Snyder
2002-01-19  8:57   ` Andrew Cagney
2002-01-19  9:00     ` Daniel Jacobowitz
2002-01-20 10:33       ` Andrew Cagney
2002-01-20 10:36         ` Daniel Jacobowitz
2002-01-20 11:00           ` Andrew Cagney [this message]
2002-01-20 11:05             ` Daniel Jacobowitz
2002-01-20 11:18               ` Andrew Cagney
2002-01-20  0:30 ` Eli Zaretskii
2002-01-20 11:32 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C4B13D1.90007@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox