From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30301 invoked by alias); 13 Jan 2002 15:59:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30269 invoked from network); 13 Jan 2002 15:59:57 -0000 Received: from unknown (HELO localhost.cygnus.com) (24.114.42.213) by sources.redhat.com with SMTP; 13 Jan 2002 15:59:57 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.cygnus.com (Postfix) with ESMTP id EBE743CFC; Sun, 13 Jan 2002 10:59:56 -0500 (EST) Message-ID: <3C41AEFC.2070201@cygnus.com> Date: Sun, 13 Jan 2002 07:59:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.7) Gecko/20020103 X-Accept-Language: en-us MIME-Version: 1.0 To: Keith Seitz Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] varobj.c c++ fixes References: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-01/txt/msg00342.txt.bz2 > 2002-01-07 Keith Seitz > > * varobj.c (varobj_set_value): Make sure that there were no > errors evaluating the object before attempting to set its > value. > value_cast now properly adjusts VALUE_ADDRESS for baseclasses, > so this offset adjustment is no longer necessary. > (create_child): Don't set the error flag if the child is > a CPLUS_FAKE_CHILD. > (value_of_child): If value_fetch_lazy fails, return NULL > so that callers will be notified that an error occurred. > (c_value_of_variable): Delay check of variable's validity > until later. We actually want all structs and unions to have > the value "{...}". > Do not return "???" for variables which could not be evaluated. > This error condition must be returned to the caller so that it > can get the error condition from gdb. > (cplus_name_of_child): Adjust index for vptr before figuring > out the name of the child. > (cplus_value_of_child): If a child's (real) parent is not valid, > don't even bother trying to give a value for it. Just return > an error. Change all instances in this function. > (cplus_type_of_child): If our parent is one of the "fake" > parents, we need to get at the type of the real parent, and > derive the child's true type using this information. > > Outch, that broken. Sigh. Yes, ok. Andrew