From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20352 invoked by alias); 10 Jan 2002 18:28:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20311 invoked from network); 10 Jan 2002 18:28:54 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 10 Jan 2002 18:28:54 -0000 Received: from telocity.telocity.com (taarna.sfbay.redhat.com [205.180.230.102]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with SMTP id KAA08673; Thu, 10 Jan 2002 10:28:47 -0800 (PST) Message-ID: <3C3DDC5D.6C74@redhat.com> Date: Thu, 10 Jan 2002 10:28:00 -0000 From: Michael Snyder X-Mailer: Mozilla 3.04 (Win95; I) MIME-Version: 1.0 To: Michael Elizabeth Chastain CC: gdb-patches@sources.redhat.com, jason@redhat.com Subject: Re: PATCH to testsuite/gdb.c++/namespace.exp References: <200201101806.MAA25038@duracef.shout.net> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-01/txt/msg00238.txt.bz2 Michael Elizabeth Chastain wrote: > > Michael Snyder wrote: > > Would it not be better, then, if the test accepted both > > \0 and \000? > > I thought about that. It would be better; and if I had written the > patch, I would have written it that way. > > But there's so much to do in C++ land, and so little time, that I'd > rather let it be. I'm 100x more worried about things like this: > > # native i686-pc-linux-gnu > # gdb HEAD (2001-12-22) > # gcc 2.95.3 > # -gdwarf-2 > print this^M > $1 = (A * const) 0xa^M > (gdb) PASS: gdb.c++/method.exp: print this (in foo) > > gdb is printing an incorrect value and the testsuite does not catch it. > This is a bug in gdb and a shortfall in the testsuite and it affects > real users. > > I am organizing my life so that I have more time to care about bugs > like that. That means conserving attention on lesser things, to their > detriment. It's an attention-triage question. That's OK, your opinion is all I crave... > But if this issue bothers you enough to submit a patch, I will approve it. Taking that for approval, I have checked in the following: 2002-01-10 Michael Snyder * gdb.c++/namespace.exp: Accept both '\0' and '\000'. Index: namespace.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.c++/namespace.exp,v retrieving revision 1.10 diff -c -3 -p -r1.10 namespace.exp *** namespace.exp 2002/01/10 17:48:03 1.10 --- namespace.exp 2002/01/10 18:24:52 *************** gdb_test "up" ".*main.*" "up from marker *** 80,86 **** send_gdb "print 'AAA::c'\n" gdb_expect { ! -re "\\$\[0-9\]* = 0 '\\\\0'\r\n$gdb_prompt $" { pass "print 'AAA::c'" } -re ".*$gdb_prompt $" { fail "print 'AAA::c'" } timeout { fail "(timeout) print 'AAA::c'" } } --- 80,86 ---- send_gdb "print 'AAA::c'\n" gdb_expect { ! -re "\\$\[0-9\]* = 0 '\\\\(0|000)'\r\n$gdb_prompt $" { pass "print 'AAA::c'" } -re ".*$gdb_prompt $" { fail "print 'AAA::c'" } timeout { fail "(timeout) print 'AAA::c'" } }