From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11971 invoked by alias); 5 Jan 2002 20:59:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11929 invoked from network); 5 Jan 2002 20:59:52 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 5 Jan 2002 20:59:52 -0000 Received: from redhat.com (reddwarf.cygnus.com [205.180.231.12]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id MAA27421; Sat, 5 Jan 2002 12:59:34 -0800 (PST) Message-ID: <3C376817.73D98217@redhat.com> Date: Sat, 05 Jan 2002 12:59:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Mailer: Mozilla 4.76 [en] (X11; U; Linux 2.4.2-2smp i686) X-Accept-Language: en MIME-Version: 1.0 To: Andrew Cagney CC: thorpej@wasabisystems.com, Mark Kettenis , gdb-patches@sourceware.cygnus.com Subject: Re: [patch] Overhaul i386nbsd-nat.c, add support for XMM + ELF core files References: <20020104160746.H9599@dr-evil.shagadelic.org> <20020104190350.K9599@dr-evil.shagadelic.org> <3C3671C2.253B6799@redhat.com> <3C3675C1.8090805@cygnus.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-01/txt/msg00077.txt.bz2 Andrew Cagney wrote: > > > (fill_gregset): Use regcache_collect. > > > > > > Are you concerned about threads? regcache_collect is not thread-aware. > > I don't think that is a problem here. The code it is replacing was > using registers[] directly. regcache_collect() is definitly less evil > than registers[] :-) Definitely. > Oh, and released versioins of NetBSD don't have kernel level threads. OK, then it's not an issue.