From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17630 invoked by alias); 5 Jan 2002 18:34:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17603 invoked from network); 5 Jan 2002 18:34:49 -0000 Received: from unknown (HELO localhost.cygnus.com) (24.114.42.213) by sources.redhat.com with SMTP; 5 Jan 2002 18:34:49 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.cygnus.com (Postfix) with ESMTP id 8BF113C83; Sat, 5 Jan 2002 13:34:49 -0500 (EST) Message-ID: <3C374749.30805@cygnus.com> Date: Sat, 05 Jan 2002 10:34:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.7) Gecko/20020103 X-Accept-Language: en-us MIME-Version: 1.0 To: tromey@redhat.com, Daniel Berlin Cc: Eli Zaretskii , gdb-patches@sources.redhat.com Subject: Re: Patch: completion -vs- duplicates References: <87k7uw1wdh.fsf@creche.redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-01/txt/msg00074.txt.bz2 > "Daniel" == Daniel Berlin writes: > > > Eli> The rest--how to display the candidates, whether to filter out > Eli> duplicates, etc.--is up to the UI's completion machinery. > > It always makes sense to filter duplicates when doing textual > completion. What value can there be in completing to the second of > two identical items? Ha, that code. I suspect you're both right. 2c worth. The underlying code should be using the most efficient mechanism available to complete things. However the ``(gdb) complete'' command should be stripping duplicates. Tom, what exactly does Insight need? Probably should do the right thing and MI the interface. Andrew