From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9525 invoked by alias); 4 Jan 2002 01:11:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9475 invoked from network); 4 Jan 2002 01:11:43 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 4 Jan 2002 01:11:43 -0000 Received: from redhat.com (reddwarf.cygnus.com [205.180.231.12]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id RAA27182; Thu, 3 Jan 2002 17:11:34 -0800 (PST) Message-ID: <3C35002F.D93E8D94@redhat.com> Date: Thu, 03 Jan 2002 17:11:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Mailer: Mozilla 4.76 [en] (X11; U; Linux 2.4.2-2smp i686) X-Accept-Language: en MIME-Version: 1.0 To: Daniel Jacobowitz CC: gdb-patches@sources.redhat.com Subject: Re: [RFA] Don't use thread_db on corefiles References: <20011213114847.A17989@nevyn.them.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-01/txt/msg00017.txt.bz2 Daniel Jacobowitz wrote: > > This patch fixes a really frustrating internal error when you open the > coredump of a multithreaded application. Depending on your kernel, either > the core has threads (corefile.c supports this just fine) or it doesn't. > Neither way will opening libthread_db work right. > > This patch isn't quite complete, because strange things happen when you > connect to a remote target too. But fixing that requires a little more > fiddling. > > Is this OK? Daniel, sorry for the delay in getting back to you on this. Now that I've had a chance to think about it, I agree that this is the right thing to do. Only I'd like to make it a separate "if" and just goto quit -- since it is not related to the "if" that's in there now. Is that OK with you? If you want you can just check in your patch as is, and I'll make mine as a separate change. Michael > > -- > Daniel Jacobowitz Carnegie Mellon University > MontaVista Software Debian GNU/Linux Developer > > 2001-12-13 Daniel Jacobowitz > > * thread-db.c (thread_db_new_objfile): Don't use thread_db on > corefiles. > > Index: thread-db.c > =================================================================== > RCS file: /cvs/src/src/gdb/thread-db.c,v > retrieving revision 1.18 > diff -u -r1.18 thread-db.c > --- thread-db.c 2001/10/13 15:04:02 1.18 > +++ thread-db.c 2001/12/13 16:43:08 > @@ -482,7 +482,9 @@ > { > td_err_e err; > > - if (objfile == NULL) > + /* Don't attempt to use thread_db on targets which can not run > + (core files). */ > + if (objfile == NULL || !target_has_execution) > { > /* All symbols have been discarded. If the thread_db target is > active, deactivate it now. */