Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@cygnus.com>
To: Jim Blandy <jimb@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: fix start symbol matching again
Date: Wed, 19 Dec 2001 09:50:00 -0000	[thread overview]
Message-ID: <3C20D221.B2E0EA12@cygnus.com> (raw)
In-Reply-To: <20011219071008.EE0625E9D8@zwingli.cygnus.com>

Jim Blandy wrote:
> 
> If the comment isn't clear, let me know.  It's a little late, and I'm
> not writing very well.

At this point, I'm kinda unclear on what problem you're fixing; 
but if it's this difficult, we could just make the $START symbol
a configurable variable.  Default it to "_start" but allow it to
be set to "start" by such target architectures as need to do so.

> 
> 2001-12-19  Jim Blandy  <jimb@redhat.com>
> 
>         * gdb.asm/asm-source.exp (info symbol): Take another shot at
>         anchoring the pattern matching the entry point symbol's name.
> 
> Index: gdb/testsuite/gdb.asm/asm-source.exp
> ===================================================================
> RCS file: /cvs/cvsfiles/devo/gdb/testsuite/gdb.asm/asm-source.exp,v
> retrieving revision 1.24
> diff -c -r1.24 asm-source.exp
> *** gdb/testsuite/gdb.asm/asm-source.exp        2001/12/17 14:57:49     1.24
> --- gdb/testsuite/gdb.asm/asm-source.exp        2001/12/19 07:06:11
> ***************
> *** 159,171 ****
>   set entry_symbol ""
>   send_gdb "info symbol 0x$entry_point\n"
>   gdb_expect {
> !     -re "info symbol 0x$entry_point\[\r\n\]*" {
> !       exp_continue
> !     }
> !     -re "^(.*) in section .*$gdb_prompt $" {
> !         # It's important to anchor the pattern above at the beginning
> !         # of the line.  Without that carat, the (.*) may end up
> !         # matching the empty string.
>         set entry_symbol $expect_out(1,string)
>         pass "info symbol"
>       }
> --- 159,172 ----
>   set entry_symbol ""
>   send_gdb "info symbol 0x$entry_point\n"
>   gdb_expect {
> !     -re "info symbol 0x$entry_point\[\r\n\]+(\[^\r\n\]*) in section .*$gdb_prompt $" {
> !         # We match the echoed `info symbol' command here, to help us
> !         # reliably identify the beginning of the start symbol in its
> !         # output.  We have to start matching exactly at the beginning
> !         # of the line, no earlier or later.  You might think we could
> !         # just use '^', but unfortunately, in expect, '^' matches the
> !         # beginning of the unmatched input, not necessarily the
> !         # beginning of a line.
>         set entry_symbol $expect_out(1,string)
>         pass "info symbol"
>       }


  reply	other threads:[~2001-12-19 17:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-18 23:09 Jim Blandy
2001-12-19  9:50 ` Michael Snyder [this message]
2002-01-17 16:18 ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C20D221.B2E0EA12@cygnus.com \
    --to=msnyder@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox