Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Corinna Vinschen <vinschen@redhat.com>
Cc: gdb-patches <gdb-patches@sources.redhat.com>
Subject: Re: Added myself as XStormy16 maintainer in MAINTAINERS
Date: Mon, 17 Dec 2001 10:47:00 -0000	[thread overview]
Message-ID: <3C1E3DBF.4030601@cygnus.com> (raw)
In-Reply-To: <20011217190422.A15417@cygbert.vinschen.de>

> On Mon, Dec 17, 2001 at 11:05:50AM -0500, Andrew Cagney wrote:
> 
>> > As the subject says...  I added myself as the maintainer for
>> > the new Sanyo XStormy16 target under the obvious fix rule.
> 
>> 
>> 
>> Not 100% obvious :-) You beat me to sending out an e-mail about this 
>> (we'd exchanged e-mail about it) :-/.  Can you also add a ``,-Werror'' 
>> to the end of the MAINTAINERS line and an entry/section in the NEWS file.
> 
> 
> I don't understand the need for the -Werror flag, though.


(Strictly speaking ``,-Werror'' :-)

The ``,-Werror'' documents that you target is of good quality since that 
code contains no compiler warnings (using GDB's select list).  (To be 
honest, if someone asked for an example on how to target GDB, I'd 
probably point them at your code.)

This in turn means that it is reasonable for you to expect someone 
making an obvious change (such as an interface change across all 
targets) to, as part of their testing, ensure that your target sill 
compiles without warnings.  On the other hand, the Arm doesn't have this 
requirement since, thanks to third party code, it can't be compiled with 
``-Werror''

For instance, my byte order changes, which are across targets, are being 
checked by me firstly compiling all targets and secondly by confirming 
that all those GDB's start (without an internal error).

does this help?
Andrew




  reply	other threads:[~2001-12-17 18:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-17  7:55 Corinna Vinschen
2001-12-17  8:05 ` Andrew Cagney
2001-12-17 10:05   ` Corinna Vinschen
2001-12-17 10:47     ` Andrew Cagney [this message]
2001-12-17 11:06       ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C1E3DBF.4030601@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vinschen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox