From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2698 invoked by alias); 11 Dec 2001 23:45:34 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2653 invoked from network); 11 Dec 2001 23:45:31 -0000 Received: from unknown (HELO localhost.cygnus.com) (205.180.231.71) by sources.redhat.com with SMTP; 11 Dec 2001 23:45:31 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.cygnus.com (Postfix) with ESMTP id 771973D60; Tue, 11 Dec 2001 15:16:19 -0800 (PST) Message-ID: <3C1693C3.9000106@cygnus.com> Date: Tue, 11 Dec 2001 15:45:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.6) Gecko/20011207 X-Accept-Language: en-us MIME-Version: 1.0 To: gdb-patches , Corinna Vinschen Subject: Re: [RFA]: port to Sanyo XStormy16 CPU References: <20011210121151.H740@cygbert.vinschen.de> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2001-12/txt/msg00315.txt.bz2 > Corinna > > gdb ChangeLog: > > 2001-12-10 Corinna Vinschen > > * Makefile.in: Add support for xstormy16. > * configure.tgt: Ditto. > * xstormy16-tdep.c: New file. > * config/xstormy16/xstormy16.mt: New file. > > gdb/testsuite ChangeLog: Yes. Your code is fine. The comments are very much appreciated. Just the usual style things: can I suggest making macro's like TYPE_IS_SCALAR functions; can you please put the .c files through gdb/gdb_indent.sh so it matches GDB's indentation style. > 2001-12-10 Corinna Vinschen > > * gdb.asm/asm-source.exp: Add support for xstormy16. > * gdb.asm/configure.in: Ditto. > * gdb.asm/configure: Rebuild. > * gdb.asm/xstormy16.inc: New file. > This bit would follow on as obvious. Nice to see a target including its assembler test case! Andrew