From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27953 invoked by alias); 4 Dec 2001 22:48:08 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27870 invoked from network); 4 Dec 2001 22:48:04 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 4 Dec 2001 22:48:04 -0000 Received: from cygnus.com (reddwarf.cygnus.com [205.180.231.12]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id OAA24010; Tue, 4 Dec 2001 14:48:00 -0800 (PST) Message-ID: <3C0D520C.E9016E83@cygnus.com> Date: Tue, 04 Dec 2001 14:48:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Mailer: Mozilla 4.76 [en] (X11; U; Linux 2.4.2-2smp i686) X-Accept-Language: en MIME-Version: 1.0 To: Klee Dienes CC: gdb-patches@sources.redhat.com Subject: Re: [RFC] add 'save-breakpoints' command References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2001-12/txt/msg00115.txt.bz2 Klee Dienes wrote: [...] > We've got a ton of stuff to submit, but as a warm-up, I'm starting > witha relatively minor feature-addition --- a command to save the > current set of breakpoints to a file that can be read in later. We've > been using this on our platform for a few months now, and folks seem > to like it. I've also tested the patch against the i386/Linux > testsuite ... nothing appears to break. Klee, Could you elaborate a little bit on how this change works with shlib breakpoints, what the original_type field is for, the bp_tbreakpoint type, etc.? In what circumstances is the current breakpoint type different from the original breakpoint type? Also, a couple of comments on the patch: There are several mentions of future breaks; you should probably clean those up until you're ready to submit that feature. And the changelog says: > (set_raw_breakpoint): init new original_type field. but that change itself doesn't seem to be in the patch. get_breakpoint_count is defined but never used. I will say that I like the idea, and the implementation's not bad, but I'd like it better without that extra bit of complexity. Michael