From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cagney To: Kevin Buettner Cc: Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: [RFA] ppc-linux-nat.c: Don't use regmap[] anymore. Date: Thu, 29 Nov 2001 14:56:00 -0000 Message-id: <3C06BD1F.2070809@cygnus.com> References: <15362.34742.58613.695856@krustylu.cygnus.com> <1011129205738.ZM19235@ocotillo.lan> <3C06AC88.50403@cygnus.com> <1011129215935.ZM19472@ocotillo.lan> X-SW-Source: 2001-11/msg00580.html > On Nov 29, 4:45pm, Andrew Cagney wrote: > > >> I suspect a few more targets could do with the same treatment. >> Eliminating that hardwired regmap[] would probably help a few more targets. > > > Perhaps. But, I think each target better have good reasons for doing > so before undertaking such a transformation. Replacing the hardwired > regmap[] with a function with the same constants hardwired into it > doesn't accomplish much (aside from slowing things somewhat). The problem is, they are not constant. Because of limitations in the way other parts of GDB currently work, an architecture change can cause those offsets to change :-( Check x86-64 vs i386. I don't think performance is an issue here. enjoy, Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25916 invoked by alias); 29 Nov 2001 22:56:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.cygnus.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25895 invoked from network); 29 Nov 2001 22:56:32 -0000 Received: from unknown (HELO localhost.cygnus.com) (216.138.202.10) by hostedprojects.ges.redhat.com with SMTP; 29 Nov 2001 22:56:32 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.cygnus.com (Postfix) with ESMTP id 529273DE8; Thu, 29 Nov 2001 17:56:31 -0500 (EST) Message-ID: <3C06BD1F.2070809@cygnus.com> Date: Tue, 20 Nov 2001 08:47:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.3) Gecko/20011020 X-Accept-Language: en-us MIME-Version: 1.0 To: Kevin Buettner Cc: Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: [RFA] ppc-linux-nat.c: Don't use regmap[] anymore. References: <15362.34742.58613.695856@krustylu.cygnus.com> <1011129205738.ZM19235@ocotillo.lan> <3C06AC88.50403@cygnus.com> <1011129215935.ZM19472@ocotillo.lan> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2001-11/txt/msg00365.txt.bz2 Message-ID: <20011120084700.phlb7Bh69uCOjemhrj68n-w0iUCiotGLakp2KaOv8Bs@z> > On Nov 29, 4:45pm, Andrew Cagney wrote: > > >> I suspect a few more targets could do with the same treatment. >> Eliminating that hardwired regmap[] would probably help a few more targets. > > > Perhaps. But, I think each target better have good reasons for doing > so before undertaking such a transformation. Replacing the hardwired > regmap[] with a function with the same constants hardwired into it > doesn't accomplish much (aside from slowing things somewhat). The problem is, they are not constant. Because of limitations in the way other parts of GDB currently work, an architecture change can cause those offsets to change :-( Check x86-64 vs i386. I don't think performance is an issue here. enjoy, Andrew