Re: [patch] target triplet for Microblaze.

Joel Brobecker
2010-11-18T17:10:43Z

> The CVS head can't accept microblaze*-(manufacturer)-elf and
> microblaze*-(manufacturer)-linux* as the target triplet. This
> behavior is not based upon the description in Autobook.
> http://sourceware.org/autobook/autobook/autobook_17.html

I don't mind allowing another manufacturer than xilinx in the target
triplet for the microblaze, but I'm just curious. Are there any others?
If that's the case, perhaps we want to adjust the comments saying
"Xilinx Microblaze" and remove "Xilinx"...

Also, `microblaze*-linux-*' is there to allow "microblaze-linux-gnu".
I'm not sure this is really kosher or not. I would think not (we're in
danger of thinking that the OS name is "gnu" rather than "linux". But
keeping it if needed shouldn't be too much of a burden as long as this
is limited to configure.tgt.

> 2010-11-18 Masaki Muranaka <monaka@monami-software.com>
>
> * configure.tgt: Accept microblaze*-*-linux* for linux target
> and microblaze*-*-* for as target.

Other than that, this seems fine to me. Cc'ing Michael Eager
in case he has any additional comment.

> - - - - -
> diff --git a/gdb/configure.tgt b/gdb/configure.tgt
> index bca2260..e065e70 100644
> --- a/gdb/configure.tgt
> +++ b/gdb/configure.tgt
> @@ -323,14 +323,14 @@ mep-*-*)
> # No sim needed. Target uses SID.
> ;;
>
> -microblaze*-linux-*)
> +microblaze*-linux-*|microblaze*-*-linux*)
> # Target: Xilinx MicroBlaze running Linux
> gdb_target_obs="microblaze-tdep.o microblaze-linux-tdep.o microblaze-rom.o
> monitor.o dsrec.o solib.o solib-svr4.o corelow.o \
> symfile-mem.o linux-tdep.o"
> gdb_sim=../sim/microblaze/libsim.a
> ;;
> -microblaze*-xilinx-*)
> +microblaze*-*-*)
> # Target: Xilinx MicroBlaze running standalone
> gdb_target_obs="microblaze-tdep.o microblaze-rom.o monitor.o dsrec.o"
> gdb_sim=../sim/microblaze/libsim.a

--
Joel